From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433A9C6379F for ; Fri, 3 Feb 2023 14:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232926AbjBCOex (ORCPT ); Fri, 3 Feb 2023 09:34:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233355AbjBCOen (ORCPT ); Fri, 3 Feb 2023 09:34:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9103C1C59D for ; Fri, 3 Feb 2023 06:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675434832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QVQjsvvXC5vAa55XgbnpLQZ7ycccPtxDGUTVFYgFp7U=; b=AsQoeRQUoXF06E8GG4hOFVjtLFOqD90puxdOeHL9PJQqsjq8FTRxRqj5ayVwS7YLc6jym1 LdSekvX16hYPOX6sjeg1tqhbF+JNgboxiBkaC26yoRQ5bUEL6zTpL5S8IAIT16osxU1ZmL WXzOm0z7tmxvODDQgB6XBfQ3IFGV/Lk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-60-VJRytsMQNFalwC0GN34H-A-1; Fri, 03 Feb 2023 09:33:50 -0500 X-MC-Unique: VJRytsMQNFalwC0GN34H-A-1 Received: by mail-wm1-f71.google.com with SMTP id k9-20020a05600c1c8900b003dc5dec2ac6so4702701wms.4 for ; Fri, 03 Feb 2023 06:33:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QVQjsvvXC5vAa55XgbnpLQZ7ycccPtxDGUTVFYgFp7U=; b=P46VChaoRizouvJNJroR1TOwQQNsxikmM4F2Jv0UBZZHo0rEp6yRu66G+uRwP3+kTw 8zHCpm5ndVXvBv1+CdYWLBBvesNOvSDosjhD3lqOhjMUomcpIyF1NCIT5w2lP70aErWT efInXTsvPceYiELkBZEA4G5T7OUanYid5AaPZRGbq8QON7LYRTdbD9Bx0YqnEjLQ5/qg IBhR8qij1Eb2lqVsHvgt/Yo/Wdt75haKNb1ZTT6LeZ7qYilwLFjpSJDVddkB4gmuohjV e+VnZVtaBxov2hvs52uk0IyYY8ITBGaqEc7Kmn/qgVQH+NIy3b3Rvo19Kzyf5qTzWEJh lFWw== X-Gm-Message-State: AO0yUKUNFK9R6oB7Of17OuS/YExL2oisHWEMn+uwi1UJDVlXpCu91fQ0 OlzfS3oftzizT4wlIgeQ492cafgdzXCpDjmM3jJP4+av5cx8HbCYhLYpUjw8UacFvvjfJHGJ+wN prD+liv+b98bdtjELpShj0ekzLGGk X-Received: by 2002:a05:600c:3514:b0:3df:ead3:c6fc with SMTP id h20-20020a05600c351400b003dfead3c6fcmr1739764wmq.17.1675434828376; Fri, 03 Feb 2023 06:33:48 -0800 (PST) X-Google-Smtp-Source: AK7set+nCaLsRgMPjXxFJ2S9nOzpB4vodjtO+Yac8mpKGPJpDWQMNBTnVH2IJfyVyYdKVED3TZv5Cg== X-Received: by 2002:a05:600c:3514:b0:3df:ead3:c6fc with SMTP id h20-20020a05600c351400b003dfead3c6fcmr1739731wmq.17.1675434828065; Fri, 03 Feb 2023 06:33:48 -0800 (PST) Received: from [192.168.3.108] (p5b0c6376.dip0.t-ipconnect.de. [91.12.99.118]) by smtp.gmail.com with ESMTPSA id o35-20020a05600c512300b003cffd3c3d6csm3239260wms.12.2023.02.03.06.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 06:33:47 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 15:33:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230129124235.209895-5-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 29.01.23 13:42, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline as a generic > implementation of pfn_valid() and drop its per-architecture definitions. > > Signed-off-by: Mike Rapoport (IBM) > Acked-by: Arnd Bergmann > Acked-by: Guo Ren # csky > Acked-by: Huacai Chen # LoongArch > Acked-by: Stafford Horne # OpenRISC > --- LGTM with the fixup Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb