Re: [PATCH RFC v3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c

Finn Thain
2023-08-16T10:41:19Z

On Wed, 16 Aug 2023, Finn Thain wrote:

> On Wed, 16 Aug 2023, Michael Schmitz wrote:
>
> > Instead of doing that for each call to pata_falcon_data_xfer(), I'd
> > rather find the relevant bits from the module parameter at device probe
> > time, and set the device-scope bit mask accordingly.
> >
>
> Good idea -- I see why you'd want to optimize pata_falcon_data_xfer(). But
> you don't need a device-scope bit mask, you need a device-scope bit, which
> could be obtained just by comparing private_data with NULL.
>

You're right, of course -- you need two bits per port. Sorry for the
noise.