Re: [PATCH RFC v3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c

Michael Schmitz
2023-08-16T07:28:49Z

Hi Finn,

Am 16.08.2023 um 17:29 schrieb Finn Thain:
>
> On Wed, 16 Aug 2023, Michael Schmitz wrote:
>
>>
>> Right - I also wonder whether using priv->swap_data to skip the bit test in
>> the most likely case (no byte swapping) is actually worth it.
>>
>
> Given it's a platform device that's only ever instantiated once, you could
> just use the module-scope variable rather than device-scope.

The Q40 platform device data specify two possible sets of IO and memory
resources, that might mean you can have up to two IDE interfaces on Q40.
Is that correct, Richard?

I'd have to change the probe logic to assign bits 1 and 2 to the first
interface, and 3 and 4 to the second to make full use of the
device-scope bitmasks.

>
> BTW, the patch description could state some of the implications for the
> default setting i.e. interoperability with the vendor operating system
> (and IDE disks from Atari Falcon I guess) as opposed to interoperability
> with everyone else.

I'll add that to the commit message.

>
>> I'll split this into bugfix and byte swap parts
>>
>> Where should this go - linux-ide for sure, but is Bartlomiej still the
>> correct maintainer?
>>
>
> The latest MAINTAINERS file says,
>
> $ scripts/get_maintainer.pl -f drivers/ata/pata_falcon.c
> Sergey Shtylyov <s.shtylyov@omp.ru> (reviewer:LIBATA PATA DRIVERS)
> Damien Le Moal <dlemoal@kernel.org> (maintainer:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers))
> linux-ide@vger.kernel.org (open list:LIBATA PATA DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> See also c4f9c8bbcc24 and fd86194aca1f.

Thanks.

Cheers,

Michael