Re: [PATCH] m68k: fix TT bootup freeze / unexpected (SCU) interrupt messages

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Eero,

thanks for your patch!

On 24/06/24 11:25, Eero Tamminen wrote:
> Avoid freeze on Atari TT / MegaSTe boot with continues messages of:
> 	unexpected interrupt from 112
>
> Which was due to VBL interrupt being enabled in SCU sys mask, but
> there being no handler for that any more.
>
> Fixes: 1fa0b29f3a43f9dd

Fixes: 1fa0b29f3a43f9dd ("fbdev: Kill Atari vblank cursor blinking")

Your Signed-off-by needed as well. And you might want to add:

Link: 
https://lore.kernel.org/all/9aa793d7-82ed-4fbd-bce5-60810d8a9119@helsinkinet.fi

before the signed-off tag.

With that addressed:

Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>

> Reported-By: Nicolas Pomarède and Christian Zietz
>
> (Bug and fix verified first on real Atari TT by Christian Zietz,
> this patch later on in Hatari emulator.)
> ---
>   arch/m68k/atari/ataints.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/m68k/atari/ataints.c b/arch/m68k/atari/ataints.c
> index 230203ffb..fa189eeb7 100644
> --- a/arch/m68k/atari/ataints.c
> +++ b/arch/m68k/atari/ataints.c
> @@ -303,11 +303,7 @@ void __init atari_init_IRQ(void)
>   
>   	if (ATARIHW_PRESENT(SCU)) {
>   		/* init the SCU if present */
> -		tt_scu.sys_mask = 0x10;		/* enable VBL (for the cursor) and
> -									 * disable HSYNC interrupts (who
> -									 * needs them?)  MFP and SCC are
> -									 * enabled in VME mask
> -									 */
> +		tt_scu.sys_mask = 0x0;		/* disable all interrupts */
>   		tt_scu.vme_mask = 0x60;		/* enable MFP and SCC ints */
>   	} else {
>   		/* If no SCU and no Hades, the HSYNC interrupt needs to be