Re: [PATCH 1/2] m68k: Drop Atari EtherNAT support when it's not configured in

[Eero Tamminen <oak@helsinkinet.fi>]

Hi,

On 23.9.2024 0.58, John Paul Adrian Glaubitz wrote:
> On Mon, 2024-09-23 at 00:48 +0300, Eero Tamminen wrote:
>> Not having it configured, but crash backtraces going through its IRQ
>> handling code, is confusing (found while debugging issues in Atari
>> emulation).
> 
> Please rephrase the patch title. The word "drop" has a very specific
> meaning in this context, namely removing a feature. I would rather
> call it "disable".

Maybe "Call Atari EtherNAT functions only when it's configured in"?


> Also, I think the longer description is slightly hard to parse due to
> too much brevity.

Would this be easier to parse?

"Found while debugging emulation problems.  EtherNAT functions were 
visible in some backtraces, although EtherNAT config option was 
disabled, and emulator did not support EtherNAT."

(This is from many years ago, these patches have been part of Hatari 
emulator, I just haven't posted them here before.)


	- Eero