From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514C9C4338F for ; Sun, 25 Jul 2021 07:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15AC460E0C for ; Sun, 25 Jul 2021 07:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbhGYG40 (ORCPT ); Sun, 25 Jul 2021 02:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbhGYG4Z (ORCPT ); Sun, 25 Jul 2021 02:56:25 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC418C061757 for ; Sun, 25 Jul 2021 00:36:55 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so9854352pjd.0 for ; Sun, 25 Jul 2021 00:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=cRsO3FZQligq2YqxLMdcdDF26DSuredfJCBANd1levY=; b=l3DQPP+Zkg58hPwlGMwI7jn0R2YagIp5wrITxbJu50InVn59vk9TNs98E4P8iNutRu FWrWP6rHJYr2J4TckQCIv72iJJ8/rC318XkBkjXJGMWTKafmGK13Ops0M7SJtbC+0lkd 9cjDBiNZvjGkie1KfCgDR3oYYAQWqmG02uVd514S/8XzEQBoSUbS7S6sDm99gaTlta/r bsIeYNYMV+Q0I90oNUmUxZLhntbrchnqh1Fkl6niAM2XGDoc6roieUV7gs37QVlW1mnw 6k8tPRneznlOoKapUYqECPoQd5H88/Nu3au7lSOaKtrWOwUXiEATNymQmBFo41Adv8E2 mrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cRsO3FZQligq2YqxLMdcdDF26DSuredfJCBANd1levY=; b=UFBb3j+rpGqBsaJH8SfCzCnu9qkNoDam76xPJy2bqSisgL/5U2cW1hdSI1m1/ckUsT 73gs6wfBPrKZrCqC0ce7A2wn6nNHWvtSgoGhq+pc1r9/+GFFcpBF99soedg93lrp7j8c 7bGN1sn/+mWAU0WpHvNY+7xOU3zC1r7uFJ+uXK8jyYdGRM7NOKQyJf6lABXe5/zT6De4 fhBLNpZLg+RadvOwx+pk4fTXBlFVuA0w1W9z1tXbiMf9fMyXLSThPUf1BPAZVh5uELzX 0xRxYzyZ7ejPBsil6zNIhLL/cDaJa9wiEE1LhraOSrfaBQ0j1QrnVVc5ZSaVVXOchs+W Np8w== X-Gm-Message-State: AOAM530JfAhHc4BbgrkjMx2H6tlzWK61j3Mp0ISHWm2VSSt4qOHeL4K4 beptv5lnHenZ5JOdQqJmJL0= X-Google-Smtp-Source: ABdhPJwW58QSHzq2rBOb7+9q4CGKnW2z6YG+688lPfjFtaHTfTH9hrQms4YQXQFbq7NCN5OI2JqUtw== X-Received: by 2002:a17:90b:2246:: with SMTP id hk6mr8480350pjb.112.1627198615139; Sun, 25 Jul 2021 00:36:55 -0700 (PDT) Received: from [10.1.1.25] (222-152-189-37-fibre.sparkbb.co.nz. [222.152.189.37]) by smtp.gmail.com with ESMTPSA id j21sm38214050pfn.35.2021.07.25.00.36.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Jul 2021 00:36:54 -0700 (PDT) Subject: Re: RFC: remove set_fs for m68k To: Christoph Hellwig References: <969718aa-92d4-e77b-0630-f9da6c809178@gmail.com> <20210713054134.GA5880@lst.de> <90e30f50-f062-ac8d-68e7-1250c886d0e1@gmail.com> <20210713085419.GA22839@lst.de> <3acb1a9e-9133-50d4-a642-98d7046d6d4f@gmail.com> <65a95ae0-4734-68ce-ef71-7491b5534718@gmail.com> <8f470389-fe8a-90b0-19a5-68f85526b30e@gmail.com> <20210721170529.GA14550@lst.de> <20210723051126.GA31274@lst.de> Cc: Andreas Schwab , Geert Uytterhoeven , Greg Ungerer , linux-m68k@lists.linux-m68k.org, Linus Torvalds From: Michael Schmitz Message-ID: Date: Sun, 25 Jul 2021 19:36:48 +1200 User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20210723051126.GA31274@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org Hi Christoph, Am 23.07.2021 um 17:11 schrieb Christoph Hellwig: > On Fri, Jul 23, 2021 at 04:00:26PM +1200, Michael Schmitz wrote: >>> FYI, I've pushed out a new version - this contains the fix from Andreas >>> and drops all these uninlining tweaks as they very obviously cause more >>> harm than good for now. >>> >>> And sorry for the delay, life has been a little busy lately. >> >> The new version passed two rounds of tests OK - looking good so far. > > Thanks a lot! I'll wait a bit and will send it out as a formal series. Just saw this: [256262.110000] *** FORMAT ERROR *** FORMAT=0 [256262.140000] Current process id is 2969 [256262.170000] BAD KERNEL TRAP: 00000000 [256262.190000] Modules linked in: atari_scsi ne 8390p [256262.220000] PC: [<00002a8c>] resume_userspace+0x14/0x16 [256262.250000] SR: 2200 SP: 4b4338bf a2: 00000000 [256262.290000] d0: 00000008 d1: 00000003 d2: 00000ba1 d3: 00000000 [256262.300000] d4: ffffffff d5: 00000000 a0: 00000ba1 a1: 00000080 [256262.320000] Process savelog (pid: 2969, task=d81f6132) [256262.340000] Frame format=0 [256262.360000] Stack from 00c1bfa4: [256262.360000] 02108005 0d06b008 00000009 00000000 00000001 000347ba 0080ab00 00778b6c [256262.360000] 00c1be0c 0003e68e 00d11970 00000003 00000000 002c7bca 00035a66 00d11970 [256262.360000] 00778b6c 00809014 00000000 00002700 0000006d 00002600 00049ef6 [256262.470000] Call Trace: [<000347ba>] get_work_pool+0x0/0x38 [256262.480000] [<0003e68e>] wake_up_process+0x12/0x16 [256262.500000] [<002c7bca>] printk+0x0/0x18 [256262.520000] [<00035a66>] __queue_work+0x1a8/0x1be [256262.540000] [<00002700>] wait_for_initramfs+0x50/0x58 [256262.570000] [<00002600>] name_to_dev_t+0x2b0/0x360 [256262.580000] [<00049ef6>] __irq_wake_thread+0x0/0x40 [256262.600000] [256262.610000] Code: 1029 0007 660c 4cdf 073e 201f 588f dfdf <4e73> 254f 040c e308 660a 487a ffe0 60ff 002d 336e 598f 48e7 031e 486f 001c 61ff Same PC as the one I reported on the 18th. Kernel locked up hard and needing a hardware reset this time. I'll back out the top commit of your series (the one removing set_fs()) and retest. Again, this may take a few days to show any results. Cheers, Michael