From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Vineet Gupta" <vgupta@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: <linux-snps-arc@lists.infradead.org>,
<linux-m68k@lists.linux-m68k.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] bitops: __fls adjustments
Date: Thu, 26 May 2022 12:08:57 +0200 [thread overview]
Message-ID: <f0b25e5f-5493-d4e2-5bc4-f90d47966c38@intel.com> (raw)
In-Reply-To: <20220525144844.1571705-1-amadeuszx.slawinski@linux.intel.com>
On 2022-05-25 4:48 PM, Amadeusz Sławiński wrote:
> Apparently on few architectures __fls is defined incorrectly. Fix this
> by adjusting declarations to asm-generic ones.
>
> As far as I can tell there should be no functional changes, but I don't
> have devices to test it, so it was only compile tested.
>
> Amadeusz Sławiński (2):
> ARC: bitops: Change __fls to return unsigned long
> m68k: bitops: Change __fls to return and accept unsigned long
>
> arch/arc/include/asm/bitops.h | 2 +-
> arch/m68k/include/asm/bitops.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Thanks for the fixes Amadeo!
I wonder if there are more places like this to address..
Not tested but I do not see any issues with the code so:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Regards,
Czarek
prev parent reply other threads:[~2022-05-26 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 14:48 [PATCH 0/2] bitops: __fls adjustments Amadeusz Sławiński
2022-05-25 14:48 ` [PATCH 1/2] ARC: bitops: Change __fls to return unsigned long Amadeusz Sławiński
2022-05-26 3:42 ` Vineet Gupta
2022-05-27 8:37 ` Amadeusz Sławiński
2022-05-25 14:48 ` [PATCH 2/2] m68k: bitops: Change __fls to return and accept " Amadeusz Sławiński
2022-05-26 10:08 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b25e5f-5493-d4e2-5bc4-f90d47966c38@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox