Re: [PATCH v4 2/2] ata: pata_falcon: add data_swab option to byte-swap disk data

[Michael Schmitz <schmitzmic@gmail.com>]

Hi Geert,

On 23/08/23 21:10, Geert Uytterhoeven wrote:
> On Wed, Aug 23, 2023 at 11:10 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Wed, Aug 23, 2023 at 12:14 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>>> Some users of pata_falcon on Q40 have IDE disks in default
>>> IDE little endian byte order, whereas legacy disks use
>>> host-native big-endian byte order as on the Atari Falcon.
>>>
>>> Add module parameter 'data_swab' to allow connecting drives
>>> with non-native data byte order. Drives selected by the
>>> data_swap bit mask will have their user data byte-swapped to
>>> host byte order, i.e. 'pata_falcon.data_swab=2' will byte-swap
>>> all user data on drive B, leaving data on drive A in native
>>> byte order. On Q40, drives on a second IDE interface may be
>>> added to the bit mask as bits 2 and 3.
>>>
>>> Default setting is no byte swapping, i.e. compatibility with
>>> the native Falcon or Q40 operating system disk format.
>>>
>>> Cc: William R Sowerbutts <will@sowerbutts.com>
>>> Cc: Finn Thain <fthain@linux-m68k.org>
>>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Tested-by: William R Sowerbutts <will@sowerbutts.com>
>>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>>>
>>> ---
>>>
>>> Changes since v2:
>>>
>>> Geert Uytterhoeven:
>>> - only shift swap bitmask if pdev->id > 0
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Oops, I meant
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> But it never hurts to have more review tags ;-)

Thanks - I can pretty much type that one blind ...

Cheers,

     Michael

>
> Gr{oetje,eeting}s,
>
>                          Geert
>