Re: [PATCH v1 1/4] m68k - add MVME147 SCSI base address to mvme147hw.h

Michael Schmitz
2022-07-11T04:16:24Z

Hi Arns,

Am 11.07.2022 um 04:06 schrieb Arnd Bergmann:
> On Sat, Jul 9, 2022 at 2:10 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> diff --git a/arch/m68k/include/asm/mvme147hw.h b/arch/m68k/include/asm/mvme147hw.h
>> index e28eb1c0e0bf..fd8c1e4fc7be 100644
>> --- a/arch/m68k/include/asm/mvme147hw.h
>> +++ b/arch/m68k/include/asm/mvme147hw.h
>> @@ -93,6 +93,7 @@ struct pcc_regs {
>> #define M147_SCC_B_ADDR 0xfffe3000
>> #define M147_SCC_PCLK 5000000
>>
>> +#define MVME147_SCSI_BASE 0xfffe4000
>
> I think this should be an 'void *__iomem' token, not a plain integer.
> Apparently the driver internally uses a 'volatile void *', but some of
> the other front-ends are already converted to use __iomem.

I'll pass the base address through a platform data struct in the next
version to address your other concerns. Haven't seen __iomem types used
in the other drivers - two are Zorro devices, and two platform devices
(a3000 and sgiwd93). Found no other wd33c93 drivers...

Cheers,

Michael

>
> Arnd
>