From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10A0EB64DD for ; Wed, 5 Jul 2023 21:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbjGEVo3 (ORCPT ); Wed, 5 Jul 2023 17:44:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjGEVo2 (ORCPT ); Wed, 5 Jul 2023 17:44:28 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F74D19BF for ; Wed, 5 Jul 2023 14:44:25 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b898cfa6a1so5252725ad.1 for ; Wed, 05 Jul 2023 14:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1688593464; x=1691185464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TLeN5byw/2yTM2aTSNa6jricbe3xA/mbs2Hdqzc0fus=; b=Q5P8vVNbURZv8h8VFQLrk0JlDn32UnhsyhHsQax6ycxk34f0gPJdTXdemPBVAx6ix5 XVQR1gXDISQXpdfjtIGYgNJqA2c40jk+l2jXI5/BSu3Ew5B/DXLTFHpzxm7+kkHuvTqf ntYA8PTJzjSrxX+LR2lriqCwq3mxOr/THbQ54Mlh/VtxmI3jc/8rZis9yRj4dZ4oXPz1 91ivESAKqd3EdleiFskF5YQv6rRj4CurAUZiF1kmnIO9CVkSJLOxr/oVutb6cYvT49VI KSW9rXfNdZaYSecXSvRpxtCmZ/kH6y6VZh2dyscY1DuKBREcshlsuXoieE/zYy69cwQe 75VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688593464; x=1691185464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TLeN5byw/2yTM2aTSNa6jricbe3xA/mbs2Hdqzc0fus=; b=eMQEPWh2B8716PGyzw6W+8OSL89+OLP4LdTGMOVaWBuXG9nwiv/CT+Gcfdkg4vylgt gkng8FOWojJGd9Ay555d1n+E73aO+V+UgOFmpWWMwaMqBioOpv1pH/yxkO8u+qCQMAdz XMBI9BE8GhIsc2Xj1k5LksJeFZ83dvk2dVN8IVZHB8OOkGtr5RaYKyQIin+uy4x+cDUR J7XhUYfCqf8go+M8kiiJfFwPEt5pcOZWSyAdseSgujADpgVzAln81cLVkVJwssktsuFo ovdvj8uu/8iQ0e9e4dvz0kPAt1cQjBsTPp38kyGdxjDqOaD2Af/MORTAm+25HrFcoUOT le7A== X-Gm-Message-State: ABy/qLapIIDjUBctm1fcUt4cJv9hLSOfKrjKwLWhI7nrdCbUFGgYcC+8 kG6Tamw2opKLyMGlbRlvMtFHY43ZqV5wGCoR4N0= X-Google-Smtp-Source: APBJJlE59gel2YEUqbYIdSol53yTFV2xlITWpqvUVCUNsRt8bO/3zMPOP64yxkRiBJ2TfzBqRXo4KA== X-Received: by 2002:a17:902:f68c:b0:1b8:17e8:547e with SMTP id l12-20020a170902f68c00b001b817e8547emr282949plg.1.1688593464624; Wed, 05 Jul 2023 14:44:24 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id h12-20020a170902eecc00b001b89b1b99fasm5619084plb.243.2023.07.05.14.44.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 14:44:23 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 15:44:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 1/1] block: bugfix for Amiga partition overflow check patch Content-Language: en-US To: Michael Schmitz , linux-block@vger.kernel.org Cc: linux-m68k@vger.kernel.org, chzigotzky@xenosoft.de, geert@linux-m68k.org, hch@lst.de, martin@lichtvoll.de, stable@vger.kernel.org, Greg KH References: <20230620201725.7020-1-schmitzmic@gmail.com> <20230704233808.25166-1-schmitzmic@gmail.com> <20230704233808.25166-2-schmitzmic@gmail.com> <6411e623-8928-3b83-4482-6c1d1b5b2407@gmail.com> From: Jens Axboe In-Reply-To: <6411e623-8928-3b83-4482-6c1d1b5b2407@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 7/5/23 3:41?PM, Michael Schmitz wrote: > Hi Jens, > > On 6/07/23 08:42, Jens Axboe wrote: >> On 7/4/23 5:38?PM, Michael Schmitz wrote: >>> Reported-by: Christian Zigotzky >>> Fixes: b6f3f28f60 ("block: add overflow checks for Amiga partition support") >>> Cc: # 5.2 >> This is confusing - it's being marked for stable, but also labeled as >> fixing a commit that isn't even a release yet? > > True - but as you had pointed out, the commit this fixes is set in > stone. How do we ensure this bugfix is picked up as well when the > other patches are backported? Does that happen automatically, or do I > need to add a Link: tag to the patch being fixed? This: Cc: # 5.2 should be enough for it to go into stable from 5.2 and onwards. > (Greg didn't seem to object to the Fixes: as such, just to the > incorrect version prereq) I think it's really confusing... A patch should only have a Fixes tag if it's fixing a specific bug in that patch. Either it is, in which case you would not need Cc stable at all since it's only in 6.5-rc, or it isn't and you should just have the stable tag with 5.2+ as you already have. I'll apply this and remove the Fixes line, and the message id thing too. -- Jens Axboe