public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: rbm@suse.com, "Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Selvin Xavier" <selvin.xavier@broadcom.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Ido Schimmel" <idosch@nvidia.com>,
	"Petr Machata" <petrm@nvidia.com>,
	"Simon Horman" <horms@kernel.org>,
	"Saurav Kashyap" <skashyap@marvell.com>,
	"Javed Hasan" <jhasan@marvell.com>,
	"maintainer:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER"
	<GR-QLogic-Storage-Upstream@marvell.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Nilesh Javali" <njavali@marvell.com>,
	"Manish Rangankar" <mrangankar@marvell.com>,
	"Varun Prakash" <varun@chelsio.com>,
	"Alexander Aring" <aahringo@redhat.com>,
	"David Teigland" <teigland@redhat.com>,
	"Andreas Gruenbacher" <agruenba@redhat.com>,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"David Ahern" <dsahern@kernel.org>,
	"Pablo Neira Ayuso" <pablo@netfilter.org>,
	"Florian Westphal" <fw@strlen.de>, "Phil Sutter" <phil@nwl.cc>,
	"David Howells" <dhowells@redhat.com>,
	"Marc Dionne" <marc.dionne@auristor.com>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	"Xin Long" <lucien.xin@gmail.com>,
	"Jon Maloy" <jmaloy@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	"Bjorn Andersson" <bjorn.andersson@oss.qualcomm.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Luca Weiss" <luca.weiss@fairphone.com>,
	"Sven Peter" <sven@kernel.org>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"David Gow" <david@davidgow.net>,
	"Kuan-Wei Chiu" <visitorckw@gmail.com>,
	"Ryota Sakamoto" <sakamo.ryota@gmail.com>,
	"Kir Chou" <note351@hotmail.com>,
	"Kuniyuki Iwashima" <kuniyu@google.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Vikas Gupta" <vikas.gupta@broadcom.com>,
	"Bhargava Marreddy" <bhargava.marreddy@broadcom.com>,
	"Rajashekar Hudumula" <rajashekar.hudumula@broadcom.com>,
	"Markus Blöchl" <markus@blochl.de>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:M68K ARCHITECTURE" <linux-m68k@lists.linux-m68k.org>,
	"open list:INFINIBAND SUBSYSTEM" <linux-rdma@vger.kernel.org>,
	"open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@corigine.com>,
	"open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER"
	<linux-scsi@vger.kernel.org>,
	"open list:DISTRIBUTED LOCK MANAGER (DLM)" <gfs2@lists.linux.dev>,
	"open list:ETHERNET BRIDGE" <bridge@lists.linux.dev>,
	"open list:NETFILTER" <netfilter-devel@vger.kernel.org>,
	"open list:NETFILTER" <coreteam@netfilter.org>,
	"open list:RXRPC SOCKETS (AF_RXRPC)"
	<linux-afs@lists.infradead.org>,
	"open list:SCTP PROTOCOL" <linux-sctp@vger.kernel.org>,
	"open list:TIPC NETWORK LAYER"
	<tipc-discussion@lists.sourceforge.net>
Subject: Re: [PATCH 01/10 net-next v2] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs
Date: Mon, 16 Mar 2026 16:44:01 +0100	[thread overview]
Message-ID: <f62948c5-8e40-4bb6-af30-c63b79112904@kernel.org> (raw)
In-Reply-To: <20260310153506.5181-2-fmancera@suse.de>

On 10/03/2026 16:34, Fernando Fernandez Mancera wrote:
> Maintaining a modular IPv6 stack offers image size and memory savings
> for specific setups, this benefit is outweighed by the architectural
> burden it imposes on the subsystems on implementation and maintenance.
> Therefore, drop it.
> 
> Change CONFIG_IPV6 from tristate to bool. Remove all Kconfig
> dependencies across the tree that explicitly checked for IPV6=m. In
> addition, remove MODULE_DESCRIPTION(), MODULE_ALIAS(), MODULE_AUTHOR()
> and MODULE_LICENSE().
> 
> This is also replacing module_init() by device_initcall(). It is not
> possible to use fs_initcall() as IPv4 does because that creates a race
> condition on IPv6 addrconf.
> 
> Finally, modify the default configs from CONFIG_IPV6=m to CONFIG_IPV6=y
> except for m68k as according to the bloat-o-meter the image is
> increasing by 330KB~ and that isn't acceptable. Instead, disable IPv6 on
> this architecture by default. This is aligned with m68k RAM requirements
> and recommendations [1].
> 
> [1] http://www.linux-m68k.org/faq/ram.html
> 
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
> ---
> v2: updated m68k default configuration to CONFIG_IPV6=n and used
> device_initcall() instead fs_initcall() to avoid a race condition.

Don't know exavtly netdev policy about merging cover letters, but if the
cover letter does not end up merged (e.g. with b4), then please move
other bloatometer stats here. Although the best if cover letter is
simply merged.

> ---
>  arch/arm64/configs/defconfig                |  2 +-

Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # arm64

>  arch/m68k/configs/amiga_defconfig           | 45 +-------------------
>  arch/m68k/configs/apollo_defconfig          | 46 +-------------------
>  arch/m68k/configs/atari_defconfig           | 45 +-------------------
>  arch/m68k/configs/bvme6000_defconfig        | 45 +-------------------
>  arch/m68k/configs/hp300_defconfig           | 47 +--------------------
>  arch/m68k/configs/mac_defconfig             | 45 +-------------------
>  arch/m68k/configs/multi_defconfig           | 45 +-------------------
>  arch/m68k/configs/mvme147_defconfig         | 45 +-------------------
>  arch/m68k/configs/mvme16x_defconfig         | 45 +-------------------
>  arch/m68k/configs/q40_defconfig             | 45 +-------------------
>  arch/m68k/configs/sun3_defconfig            | 45 +-------------------
>  arch/m68k/configs/sun3x_defconfig           | 45 +-------------------

Thanks Fernando for addressing the comments. Great job!

Best regards,
Krzysztof

      parent reply	other threads:[~2026-03-16 15:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260310153506.5181-1-fmancera@suse.de>
2026-03-10 15:34 ` [PATCH 01/10 net-next v2] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs Fernando Fernandez Mancera
2026-03-12  3:02   ` Jakub Kicinski
2026-03-12 15:12     ` Fernando Fernandez Mancera
2026-03-12 16:05       ` Geert Uytterhoeven
2026-03-12  7:43   ` Geert Uytterhoeven
2026-03-16 15:44   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f62948c5-8e40-4bb6-af30-c63b79112904@kernel.org \
    --to=krzk@kernel.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=aahringo@redhat.com \
    --cc=agruenba@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=bhargava.marreddy@broadcom.com \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=bridge@lists.linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=david@davidgow.net \
    --cc=dhowells@redhat.com \
    --cc=dsahern@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=fw@strlen.de \
    --cc=geert@linux-m68k.org \
    --cc=gfs2@lists.linux.dev \
    --cc=herbert@gondor.apana.org.au \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=jhasan@marvell.com \
    --cc=jmaloy@redhat.com \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuba@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=kuniyu@google.com \
    --cc=leon@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=lucien.xin@gmail.com \
    --cc=marc.dionne@auristor.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=markus@blochl.de \
    --cc=martin.petersen@oracle.com \
    --cc=michal.simek@amd.com \
    --cc=mrangankar@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=njavali@marvell.com \
    --cc=note351@hotmail.com \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=petrm@nvidia.com \
    --cc=phil@nwl.cc \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rajashekar.hudumula@broadcom.com \
    --cc=razor@blackwall.org \
    --cc=rbm@suse.com \
    --cc=sakamo.ryota@gmail.com \
    --cc=selvin.xavier@broadcom.com \
    --cc=skashyap@marvell.com \
    --cc=sven@kernel.org \
    --cc=teigland@redhat.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=varun@chelsio.com \
    --cc=vikas.gupta@broadcom.com \
    --cc=visitorckw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox