Re: Bug#877735: busybox: m68k build broken due to "-Os" in CFLAGS

[John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>]

On 10/05/2017 05:55 PM, Roger Shimizu wrote:
>> On second thought, I would actually recommended to revert this change
>> for all architectures. Size isn't so much a constraint anymore these
>> days, you reduce the binary by about 200k. I don't think this is worth
>> the risk of breaking something as fundemantal as busybox.
> 
> Please exclude armel, which has size limitation on initrd of d-i [0].
Hmm, ok. Is that currently actually a concern? If I'm seeing that correctly,
the "-Os" here only saved us around 200k. Does that already make a difference
on armel?

If yes, I'm also fine with something like

# On m68k, building with -Os leads to miscompiled code
ifeq (m68k,$(DEB_HOST_ARCH))
	CFLAGS := $(filter-out -Werror=format-security, ${CFLAGS})
else
	CFLAGS := $(filter-out -Werror=format-security -O2, ${CFLAGS})
endif

Adrian

-- 
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913