From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F789C433F5 for ; Wed, 20 Apr 2022 23:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383039AbiDTXDe (ORCPT ); Wed, 20 Apr 2022 19:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383037AbiDTXDd (ORCPT ); Wed, 20 Apr 2022 19:03:33 -0400 Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5023C1E3C3 for ; Wed, 20 Apr 2022 16:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650495646; x=1682031646; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=S3wrcHUGdl9LcKznCHJjFCjAB1oU2LwvM5QjcZA34fY=; b=gozbVnpPJwgBvGDoblGcclkYC8NNx5wojtRhKxnOqsDx3+esORbLrw5P 40borVwJRUEEvGEvpF9UKeqYwsuQ5PtnDVQ+vi5wR7u+C4DNaSOTpdagU TNNdzYFpnnI0+CdmkjU+1M6+wAbdQK3CnC9cGQDc0E45UthAXMTZAMr/A aqMrqt5BXInZOFBJsOliUdZZfcAWZSU2VGtvawPWbK+ww4JiYXxGdeYbY zEyrs3bVkAjmAr2zDiRY1Umz8eWbrF+76IXIOsqj0OG21cUbnkJVK9FwF EKQ+ryCKR3Gr9abyoQvUEOj79xP7QIybbv6WfJv2qPtuqSo/rZbedGdha A==; X-IronPort-AV: E=Sophos;i="5.90,276,1643644800"; d="scan'208";a="302606673" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 21 Apr 2022 07:00:45 +0800 IronPort-SDR: 0BF7nI4d0/8wX32dZqMF/+aNj3tNhT7MUYlXy4Xx5rjorTou6hs4vdlYy78SCzz0BtFyc0Y16j Q/CsnDzIPVlm8UGGS1KuyYjlelk6zP7r1wBxHOmMfeVv5xZU6aoDy0m1xXs538VJWABm7e74jn opKdY53nCAWHDbguOTtrfwGmFPiUisSiaL7ArDCFmbDZSDG0b9XAAiC7kSyuIBrQ30iPrI8wSb 6JlpvZZunZViUJXtSaEbdhHr8d8OatgGD08xwVtR2wI/8R1beXow6bni+GoIqbIdFYefVhKjOI bGrEEf9yY+xNs9N15fr7bxi1 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Apr 2022 15:31:48 -0700 IronPort-SDR: 9sXTKYSivdgHZfOQGKiFclKQ7otvMiiFzhJIXzyPBjvGi9wkcTaqITk1KSSUcquLkYjCsqGVEc YPzDRdCeqAu7+Vm5+C2JsvIG8s9BtWflZPQ+etFkGmW5RMOmLITl5RrCqzopaRNLjjQfP5+FLK BJoNWfucscRyutEtO4qIXf4+JsrRVxdan6un0Txeks48p+gomnu1GQ1vf/fmzW8aFiYr3ohEM8 A7Cc0pnKEkyq5tlfjiU72fAQ4xA0qBABRvlhxplwQaiUHUIKoxIBXenkZ4RaDJpr8H+jtGvPvV 8Gk= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Apr 2022 16:00:45 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KkGNr3d1Hz1SVp1 for ; Wed, 20 Apr 2022 16:00:44 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1650495643; x=1653087644; bh=S3wrcHUGdl9LcKznCHJjFCjAB1oU2LwvM5Q jcZA34fY=; b=D2NS7tuk1+iRdP2LXEmtP9/6hn5ZwQNV8bhVAXHTm6qx3RZWyL5 c6jousROa5m5iDPz8KDFGCCqKUQ14/8fXxb+x5u4wqoE3FKSjF+IWh2fzArJDGlV kMXNdZ+1bffcohH0WCo3xmyWq10jH8WKZiiMcbDew14H68pdOjH/l9dBXXQK7cp7 2qRoMSDlhBuTMnFp12RR8hWOc8ro6TqIrFTwNh/5ewrdZ40NPlO35+HNySdfJD5t X2iefhTMwwiq2uiGXQOqpmYE8heVo/dam/Wd9BPmhLhdH3v2+kulsKEIZ/XInTdm pGPF6aGbXgmmA+zSgg/E4dJvjGh1pWJXsLw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TEnrn2iEgu4J for ; Wed, 20 Apr 2022 16:00:43 -0700 (PDT) Received: from [10.225.163.14] (unknown [10.225.163.14]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KkGNl5hPQz1Rvlx; Wed, 20 Apr 2022 16:00:39 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 08:00:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] binfmt_flat: Remove shared library support Content-Language: en-US To: Rich Felker , Arnd Bergmann Cc: Kees Cook , Palmer Dabbelt , "Eric W . Biederman" , Niklas.Cassel@wdc.com, Al Viro , Paul Walmsley , Albert Ou , Mike Frysinger , "# 3.4.x" , Linux FS-devel Mailing List , Linux-MM , linux-riscv , linux-arch , Geert Uytterhoeven , linux-m68k , Greg Ungerer , Linux ARM , Linux-sh list , Yoshinori Sato References: <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> <20220420165935.GA12207@brightrain.aerifal.cx> <202204201044.ACFEB0C@keescook> <20220420202321.GD7074@brightrain.aerifal.cx> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220420202321.GD7074@brightrain.aerifal.cx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 4/21/22 05:23, Rich Felker wrote: > On Wed, Apr 20, 2022 at 10:04:32PM +0200, Arnd Bergmann wrote: >> On Wed, Apr 20, 2022 at 7:47 PM Kees Cook wrote: >>> >>> Yeah, I was trying to understand why systems were using binfmt_flat and >>> not binfmt_elf, given the mention of elf2flat -- is there really such a >>> large kernel memory footprint savings to be had from removing >>> binfmt_elf? >> >> I think the main reason for using flat binaries is nommu support on >> m68k, xtensa and risc-v. The regular binfmt_elf support requires >> an MMU, and the elf-fdpic variant is only available for arm and sh >> at this point (the other nommu architectures got removed over time). > > I believe I made the elf-fdpic loader so that it's capable of loading > normal non-fdpic elf files on nommu (1bde925d23), unless somebody > broke that. I also seem to recall that capability being added to the > main elf loader later. Last time I checked, building shared libraries usable with nommu riscv required gcc/ld options that were not supported for riscv (PIE related stuff). So removing the kernel support for shared flat libs is fine with me. -- Damien Le Moal Western Digital Research