From: Andreas Schwab <schwab@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Ungerer <gerg@snapgear.com>,
Gavin Lambert <gavinl@compacsort.com>,
uClinux development list <uclinux-dev@uclinux.org>,
Philippe De Muyter <phdm@macqel.be>,
Linux/m68k <linux-m68k@lists.linux-m68k.org>,
linux-arch@vger.kernel.org
Subject: Re: Writable sys_call_table (was: Re: [uClinux-dev] [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table)
Date: Mon, 18 Apr 2011 18:21:02 +0200 [thread overview]
Message-ID: <m2y637bkep.fsf@igel.home> (raw)
In-Reply-To: <201104181649.31492.arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Apr 2011 16:49:31 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> diff --git a/arch/score/kernel/sys_call_table.c b/arch/score/kernel/sys_call_table.c
> index 287369b..7be73dc 100644
> --- a/arch/score/kernel/sys_call_table.c
> +++ b/arch/score/kernel/sys_call_table.c
> @@ -7,6 +7,6 @@
> #undef __SYSCALL
> #define __SYSCALL(nr, call) [nr] = (call),
>
> -void *sys_call_table[__NR_syscalls] = {
> +const void *sys_call_table[__NR_syscalls] = {
That's not making it read-only. You need to move the const to the other
side of the pointer.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-04-18 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTimbHgmUvisE7+TCkgthejNi_zdojQ@mail.gmail.com>
2011-04-18 14:49 ` Writable sys_call_table (was: Re: [uClinux-dev] [PATCH] m68k: Merge mmu and non-mmu versions of sys_call_table) Arnd Bergmann
2011-04-18 16:21 ` Andreas Schwab [this message]
2011-04-19 7:48 ` Arnd Bergmann
2011-04-19 8:12 ` Finn Thain
2011-04-19 11:54 ` Andreas Schwab
[not found] ` <m2k4eqfocu.fsf@igel.home>
2011-04-19 12:16 ` Arnd Bergmann
2011-04-19 13:25 ` Andreas Schwab
2011-04-19 15:31 ` Finn Thain
2011-04-13 18:05 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y637bkep.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=gavinl@compacsort.com \
--cc=geert@linux-m68k.org \
--cc=gerg@snapgear.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=phdm@macqel.be \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox