Re: [PATCH 1/4] m68k/atari - stram: alloc ST-RAM pool even if kernel not in ST-RAM

Geert Uytterhoeven
2014-03-30T19:11:20Z

Hi Michael,

On Sun, Mar 30, 2014 at 1:01 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
> + pr_debug("atari_stram pool: size = %lu bytes, resource = %pR\n",
> + pool_size, &stram_pool);
> + pr_debug("atari_stram pool: start = %p, end = %p\n",
> + (void *) stram_pool.start, (void *) stram_pool.end);

Please drop this line, as it prints more or less the same as the %pR in the
line above. Also in the other block.

> + pr_debug("atari_stram pool: stram_virt_offset = %p\n",
> + (void *) stram_virt_offset);

Please use "%lx", and drop the cast to "void *". Also in the other block.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds