From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH] mvme147: use correct order of ram pages Date: Wed, 28 May 2014 11:39:20 +0200 Message-ID: References: <1401250073-16603-1-git-send-email-akong@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-out.m-online.net ([212.18.0.10]:39015 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbaE1JjZ (ORCPT ); Wed, 28 May 2014 05:39:25 -0400 In-Reply-To: (Geert Uytterhoeven's message of "Wed, 28 May 2014 09:51:39 +0200") Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Amos Kong , Linux/m68k , "netdev@vger.kernel.org" , "David S. Miller" Geert Uytterhoeven writes: >> -/* We have 16834 bytes of RAM for the init block and buffers. This places >> +/* We have 16384 bytes of RAM for the init block and buffers. This places >> * an upper limit on the number of buffers we can use. NetBSD uses 8 Rx >> * buffers and 2 Tx buffers. >> */ >> +#define M147LANCE_RAM_SIZE 16384 /* 16K */ >> #define LANCE_LOG_TX_BUFFERS 1 >> #define LANCE_LOG_RX_BUFFERS 3 > > BTW,I also find it fishy why the driver uses only 1+3 buffers, since more > RAM is available. It's 2^1+2^3. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."