From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793717283; b=CNzxGA70hdXLDlrAXW83PXsnziMGPlzoluq+QSuwBFfJjKdLKsBHOFrK+Ys0PCR3JDmI BKBaazyo+pXA8YIKn9SK/g+mcuDh0zfJL6/TC/wnC8hEry1NValyodJFM5SLEDg65NlPD Hh85mG9zBamrk2iYCsmmUZmJzxKpdMHicjfHXSU+Yh8N3mogAo8B9DMVmmCilnO0pWVkz 4elJr5Iq1c5xTWcKlE031vfPN1f6ubolHuOTtou5qu3Ydr54XH5CGGK1NK++em2ZHZ9fG P3lXyoP/1VUCDDgr88FVnr+QFLSGA4Nw/xGPOHKDHQlCTPeGuU/Pst+Th3PT8zpxXdA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793717283; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=Jt8oSnDtjWT9Rc1lRRQoEdIpZQuLDAxwiZiNGREGvEU=; b=r/wozYCH23mcYwuHrMGW/1ntWlQIRTe+N1TAwtnklwv5UW5CW6EUsIkIDrQmdw0B8vD4 OoiwO2nQReBBKFjobi8DGsYBKloV7oqZD9rpnHpZlvDIVzjX/OEN9juxYvcQ6OUvRX3S5 zOViLlJ1rYh1CzjRIwP2emvRI+RGNt1LJl3v6TK44kBPKTLEsf4cKJDJnM+8/HOvfMdAI LmViQEpPAd2Qqa62cs5FoQKe0h+HGlno2TitYdEZ0vRdsNETUydQkKYpZgUPIA/8m5B2K HGzoVixq+9JYMahjOYPsLjGDRw5bpwju+l1Qj2aGIZHrPN1RmDOqe1EMfJiy9M8scXA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZLM25BCG; arc=none smtp.remote-ip=172.105.4.254 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B983860A2627 for ; Tue, 3 Nov 2026 14:48:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B983860A2627 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZLM25BCG Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1D69B60626; Tue, 3 Nov 2026 14:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D27A1F00919; Tue, 3 Nov 2026 14:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793717281; bh=Jt8oSnDtjWT9Rc1lRRQoEdIpZQuLDAxwiZiNGREGvEU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ZLM25BCGsWNuNmJ/K9N1vryFmClM5QGd+w1e7Y/oABSSzjVbQNzdV0AlPqiqT/BZz gVjtej5uWjivTFNRb8niUA/AaCtVvzYTNAGV9gc6Mg8Q73DILuzBagqZP0YjlkS4ok 8a5PyM62d8H3SaSHls5JF7e6qN38DCKSnLe90TyyDShwSeDWLcnDwqx5NCFzJREoSZ fYkFOlYBmIxCnw6DQBk3StfjM1WgHAjuKa+F5YHphYcUyb5by0bUB2nqkyvRC6EwmM mLR9qu9/cElVYgf0F7Xq0FERhwAIiwGHNA/5lHothanOlSg0abydegRnPFqWsonMYV SucZjZpZ0qt0Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 17/38] net: pktgen: reject device names with a '/' Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-bugfixes-v1-17-59422ed3e465@kernel.org> References: <20261102-work-procfs-bugfixes-v1-0-59422ed3e465@kernel.org> <20261102-work-procfs-bugfixes-v1-17-59422ed3e465@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 14:47:59 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > "add_device" takes a name like eth0@1. Only the part in front of the > '@' has to name a network device. The rest is free text and all of it > becomes the name of a file in /proc/net/pktgen, where procfs takes a > '/' as a directory separator. So "add_device lo@a/b" makes procfs look > for a directory "lo@a" that doesn't exist and warn about it. Any user > can do that in a network namespace of its own: >=20 > name 'lo@a/b' > WARNING: fs/proc/generic.c:174 at __xlate_proc_name+0xb1/0xf0, CPU#3: b= ash/241 > Call Trace: > __proc_create+0xd0/0x9b0 > proc_create_reg+0x45/0xf0 > proc_create_data+0x77/0xf0 > pktgen_thread_write+0xd8d/0x1750 >=20 > With panic_on_warn that takes the machine down. And if "lo@a" exists > because somebody added a device of that name, procfs used to register > the new entry below that regular file, and removing "lo@a" freed both. >=20 > Reject names with a '/'. >=20 > Reported-by: Chris Mason > Fixes: e6fce5b916cd ("pktgen: multiqueue etc.") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-bugfixes-v1-0-59422ed3e465@kernel.org?part=3D17