From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793719116; b=qLB9Gb0/BAsnOXEurLImrOyYkPuvFfpZ73LJCXBaMLALnoL6CQov12jmXcGyKeVFgo32 ovRZqwV1LVkZc1QMup8dGIen9vuLIp5BLTySNil1xDzsg4MBjopG6Cf7yATSjaGgSwyON A7/4WM5v9N6zBLPzo9RxJXOpVScmPb+DLCWrHiYlVS1EwX2nPyPeVUGyBbQ6Wo9dj/LW2 2oOON9xZ5igSJclmWq4PIJGI12aQB4e4FJAoaFE0CqP/7poiLjfT+0Yu2Wz01+ZF7FJUD MBRe4JYJxJbl/K3PeOO/jAHNhwLVMYTQv7U2+LF1eJ0tmyLL6lsLL5kPnzL1CFQ6MVQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793719116; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=DJWMdpN/Mhm849XfylURVc3f+ehsUKnFgT6iodNIu2I=; b=fbEDBHpDZPqDzeOhCvMmC11qAPbBv6GvriTtAAQAG63RC3koP1SIPuf9ksP3T0LVwkGe mU3DvaSXeqG7dV+duXamWnxVVOOdQgNLsTKDeKkeMJ0+8pW5IdeqhpzuuF/yxfAAinjPa MRy+B0dJre8xDCcT7kuotMbJ06a5zOOw+qD7FKOJ9fcdO3lbNOYJW2mkxRaRihPLbNhQU JzcV0wJqH27RWh3+gcpmuw/7FoWnP8UoFLpk/XAsjmhd7D473mVjJHQCW4L7mAB7CN4Dc cgoDL3DFhGL3B+FOoJEc0mU5xnN27++OhqqUZol7mMLOX6oHxqJ4UWTWvSxgNO3wBJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VnXRLo8l; arc=none smtp.remote-ip=172.105.4.254 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09B5606F63B for ; Tue, 3 Nov 2026 15:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F09B5606F63B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=VnXRLo8l Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 42DF0609F2; Tue, 3 Nov 2026 15:18:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77D5B1F00919; Tue, 3 Nov 2026 15:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793719115; bh=DJWMdpN/Mhm849XfylURVc3f+ehsUKnFgT6iodNIu2I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VnXRLo8lld+/gqavjn9Dsw66ts+5YWypK0KuqK5iG9mI5UWXfSd0stxLTsOz2QcOw VDQPZ3ScwlwC8ArGOiDqW1zYBC5/UxJTL1APdQsB/X0Tt6H7l++QO8xYyFS10kb0ud e3oQeE2qhraAFmO+n1A6RS7j6ROSd7oXltgPL81WCyHyT6/tyeJ+gbwO5bYmUWLPuk fTjj6Q3YEHbn5drVobbZZFg/j+nCNHLhMyRYPmStuLzP1pTOjwSF23CoDnAIi6o1ZL YSYfKmCbkpYrGFdbTk2Ymk/2GWnXi2HYS6UZMoN6QTq2nVZ3hTdvcaHwRCBU+bmABN LsJp0pWLY7VcQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 05/23] PCI/proc: let procfs handle the ioctls Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261102-work-procfs-drivers-v1-5-a994bd4d3b1a@kernel.org> References: <20261102-work-procfs-drivers-v1-0-a994bd4d3b1a@kernel.org> <20261102-work-procfs-drivers-v1-5-a994bd4d3b1a@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 03 Nov 2026 15:18:33 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > The PCIIOC_* commands take and return plain values and don't touch > userspace memory. Implement ->proc_ioctl_buf() and list them with > nothing to copy. 32-bit tasks go through the same table, so the compat > hook goes away. Unknown commands fail with -ENOTTY from procfs now > instead of -EINVAL, and instead of -EPERM under lockdown, since they > never reach the handler. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261102-work-procf= s-drivers-v1-0-a994bd4d3b1a@kernel.org?part=3D5