From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793906983; b=PRohE3/IWW0CvrRmTtQqxSv5LAGpzhMOfw72nzhcnbC3sSKK8psP3GlXQzKvPKlP9IPG ps2eEPFql7ule6F0zWWGyUtXwJuV1wjMyUd/ZczTGQ8yoATi4nKh7T4B/5PkGQNFd1Lpg gTB8gUmVr4qTm3qYFJosLDsvH0ede2vnS6Op8pHH/xmFsYjcivU2yuZoyYGgRwnxnUqVu hfoSeQdVMK1zNL2IylTglVUnnWkj2x7WEZsu5acZEh8xg8sWJr02A36gbWs6pNZThKQ2J TP4Vdmay0l4j8OdOXsweDiITyeRbi87Zgebu6/jc2inpg+hFSPXfMpGLznuJBrDulvw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793906983; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=P6jpmRzymPT4r1qFhmwUt7rLPG9nXrVikl3aWyHy3zY=; b=Os/8BiO2PREwthpMV5oVceO8U+khg8qiUAokGELQUlbOmIfRdME3s5NU4Unui6ZX8emG xCXvj8tzoJKYN1DuMLuFSx9Twgf1swi3Qpcm82rhvwL30RI1oOC/9XEH++VROSlv6cQ1H IF1TVmPIdg7xwIOuAgC8mL2WfugmPiblDwFR7D18RuKq2ik4dC3wHqHa/Vs9uvEFeych+ b3wWKoELojfHWIQmdzImlBmp42MMpPtup7gEvk2rc6H7K54xqTASZ81xSUaPi/Iuz4wdd AW1TaYJN7AXz4MS/3tcF92Nxt1n2zs5RDY5dlUHNEp9TWmXK3qnHfszS64TduhCOfvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BI6MttIY; arc=none smtp.remote-ip=172.105.4.254 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95CAA6082BF3 for ; Thu, 5 Nov 2026 19:29:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 95CAA6082BF3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=BI6MttIY Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D3566601CC; Thu, 5 Nov 2026 19:29:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 506931F00919; Thu, 5 Nov 2026 19:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793906981; bh=P6jpmRzymPT4r1qFhmwUt7rLPG9nXrVikl3aWyHy3zY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BI6MttIYsBkE0g/vJZ+tIbuQi6n//HrvnT15RjmT0kcJcNcEhPSua8MjhEkmvdLBy YJ4Cl9rhWrU2J4FNfrV5LG8LjKzdoOPXpIy3l02i150qUa6eO1W62hdcJOzlm/8UaO 8YRGUFIFXaZzA8K6X+GpP9ZjU4yKSbKfjjhUBmROBGXgTGgeHdxAb0ylhCvZ99pGHi UTdy2yICxI8TI6rIlwVdpTX04WIt3mGVdeNnVRbumQIyZHqUl/9zhk34Qq091tX8nL V7uPEQ77IY3Dtg208+RDdYXIh08xvxvfPijNAYM2aPAEKdPQWQJs9yilg/Hiqm9By0 dV7TqpBHd20kg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 26/51] scsi: core: NUL-terminate what is written to the host proc files Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-bugfixes-v2-26-021c84d852e0@kernel.org> References: <20261104-work-procfs-bugfixes-v2-0-021c84d852e0@kernel.org> <20261104-work-procfs-bugfixes-v2-26-021c84d852e0@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:29:39 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > proc_scsi_host_write() copies what is written into a page and hands it > to ->write_info() without terminating it. ppa and imm parse it with > strncmp() and simple_strtoul(), which read on past what was written into > whatever the page held before. Terminate the copy. A write is at most > PROC_BLOCK_SIZE bytes, so the page always has room for that. >=20 > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-bugfixes-v2-0-021c84d852e0@kernel.org?part=3D26