From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793908147; b=jVQYU6+p+ANI89/2USjZZW8oemRH8ekcWlqdsgnCKYnrj8WhWqBFmEQ/GVIIHejqIIaj ibxpBSZxITdWquioG3rICasg44EwwQY6iGNVSn1AztG6qSMpCNSXdyxJpw1NrXLRjDWTN T+NUZwuGqEMpawPQWlyu25zMPxB39k5gWPAvkbhD12pKP9dZDEr3ZPJSWhFqNZ0TQwMZA RLhW423LkIOnS9zIXku/SQJy9silBEWv+A89as5ZfKbVHNgsd8GF3Vn+scCYt2JdBAFhc dxswGydLRO2BfDl3dysdzFgL52fieBDUTbvf0B6oH9+wbobFNJnEmwWCT0HQkOslI2Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793908147; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=qAsUIA0sJNC6e1GmhI+cxYDDQcvJjgzrcIvMQ1GtXVU=; b=P8oKb7c2BgnM+DcSmhYi26B1f5MP0rQHQqf4nABeU0lZP+oJSqBMP4QWxNcrKO6Nl/jn 6Rh1/2nirq0freNV3s3N/dNs7pfgPeZafKNJqFgZ0IMLBu+Di2pi+8ZTOTF28RvKmCKbN IDlXsmpaxo/96yyCe7w+GzDx8lp4unPbwrkByn5rd81s+uOZvji2PtraRhdgJ+Hoa+aX3 jJXVtotVCE6O8oTzH8e2Smlcpwc/xga37dsgk2sJ0SkEYt6L53FWjiBBLM+s6ihy8O7yn I5ri8wIq1rApvS19k9aXAFfKJKPUwVXFRcB7DbO7Y+PRSJXIJX3Qkpdu2+7R93T9rxQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=F7cBXcB2; arc=none smtp.remote-ip=172.234.252.31 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91891606D510 for ; Thu, 5 Nov 2026 19:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 91891606D510 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=F7cBXcB2 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 504A143B69; Thu, 5 Nov 2026 19:49:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B74E91F0089F; Thu, 5 Nov 2026 19:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793908146; bh=qAsUIA0sJNC6e1GmhI+cxYDDQcvJjgzrcIvMQ1GtXVU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=F7cBXcB2CGcv4wv0GxypQPDRPWGhJY8+iPXIIuWPXopYVWlP4LLjgo8s9BW+0AJkl 2qXmnh9DA3hSouulPkjS7IHK/WlNM3sesBzffi33UCKagGiEAnYzLjTtm7gmSPxC9N 2hxw3SAfosebdwFpwNQ3beH6vTlyrS5FawLVYmvteNZGCQvJae7Z4z+vnEFeIceCV4 S257SGAR9gCP3QkTxFVZxqim/O97/pS2SwimLTzs3wmwDlTrdncsNWnFgGwVhPA8Le 0OhQGAaBUtsDAIXzFa1j3oogZ/jVk2PR4D01woTHT8+F7FoYVB9+hd4/wxGAP7ZIBr doa7KiQ5i4Qyg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 01/26] nubus: let procfs own the seq_file of the resource files Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-drivers-v2-1-245e54e87116@kernel.org> References: <20261104-work-procfs-drivers-v2-0-245e54e87116@kernel.org> <20261104-work-procfs-drivers-v2-1-245e54e87116@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:49:04 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Get the inode from the file instead of ->private, declare the show > function and let procfs open and free the seq_file. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-drivers-v2-0-245e54e87116@kernel.org?part=3D1