From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793908155; b=jvIGDneVkpswgPc4j/TWcHE/whk7EgEYyXZa6oMBPvNXsA7a4PyxTXPNSMxU1jLpVmtN 2yNj74Cu25CJTfFQCij6bd/uSpCJEs0Z1xmWD/yIBbRxvsOSJgeMYnTObWgsw0/8YjHII QpnmU4vZPHEwzVqIxZS42zsj8yzGsD7HaQko4c63C9iHJF9W9pV8cXXPjjeluOHgk4lCW G+2wAdFQtMcDjlUa9APPSsu2Y8aHPag8/5e0PnEFcVfnmuOsq/xfku1AIdRtCHyy3s30u IKoRC5RIgDpC2FbnaQKhhYbGzNOqAd2GDFjVrY9bwf5mpf4zki+o0qm0sD9TpvY7sNQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793908155; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=6cps/enMaPjoFeCDjt0OIcQqkD6lwpn3AaQg+KoH5MA=; b=SB1Ig+snLeDK5VIIGLLHF6RjeGPj6KEEpRU3rjup6dfQTz2irHfyTJwX5Qin02T5qlYY 1ZaaD4XnVDzCmzZYCAUSo98XY3HfJLSUbeQo0shbrtwwHHEr6GJmF1nmgl07XUb9CjNiN OmidMd3VlDbQHgArL4G8PmrO0AWdlrZg1DJRkssBHCAap+HJ334Dqu3II5xBCIdCHOAHx VcID9M5TJbu/L6IF83nKZZ9AOkV6nh5F+rkd8N33tq1IMiKu8bUGQHUjCTSHSzB4M9XQN RJKlCzIaM2JYVsiAaSkJ+AXGa2s+6xookqzz5rznnjEGkk8lXcEvhjgkgDe/rEYFekw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PXQczwRB; arc=none smtp.remote-ip=172.105.4.254 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D91F606EEB6 for ; Thu, 5 Nov 2026 19:49:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4D91F606EEB6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PXQczwRB Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 857FF60210; Thu, 5 Nov 2026 19:49:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBBB71F008A2; Thu, 5 Nov 2026 19:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793908154; bh=6cps/enMaPjoFeCDjt0OIcQqkD6lwpn3AaQg+KoH5MA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PXQczwRBEXysSM7qtBjfJavsgQrZKTVx0yuwFzRJcumKzWmphnnHKjGfvN+N4Q8c7 0gnr8aWsZJTn6RiwGOM99KsCPRfdKnD2gmZGBa6cZyhsHOmKdk/p3t7dtqB+KkkxUK Tqn73tuLhq8E4PhE8YiMnhhG/iRUbAbieCFh3X1HCoAC+PQOchL+wT/c0O+sZenray 0ieAhXUCsy5aAlLaGHYJVAZtCXM0DzFCzGPvlwOyZ0NDlB0Hk+CiPhmTvHt/WW6C/N IJE4tr6U8LvpD2431eh4mGeuBUOnBIYyHAT+kFIsPzYQdWl956WMKsirJGDnRlKrLO vYsd7v/OnW/Xw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RESEND v2 04/26] PCI/proc: let procfs copy out config space reads Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Brauner" Cc: "Linus Torvalds" , "Jann Horn" , "Josef Bacik" , "Chris Mason" , "Jeff Layton" , NeilBrown , "Eric Dumazet" , "Thomas Gleixner" , "Al Viro" , "Jonathan Corbet" , "Christoph Hellwig" , "Greg Kroah-Hartman" , "Joel Granados" , "Kees Cook" , "Jan Kara" , "Jan Kara" , linux-s390@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, linux-m68k@lists.linux-m68k.org, linux-serial@vger.kernel.org, "Takashi Iwai" , linux-ext4@vger.kernel.org, "Chuck Lever" , tytso@mit.edu, "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" In-Reply-To: <20261104-work-procfs-drivers-v2-4-245e54e87116@kernel.org> References: <20261104-work-procfs-drivers-v2-0-245e54e87116@kernel.org> <20261104-work-procfs-drivers-v2-4-245e54e87116@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Nov 2026 19:49:12 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > Implement ->proc_read_buf() so procfs copies what is read to userspace > after it unpinned the entry, and read the config space into procfs' > buffer with put_unaligned_le16() and put_unaligned_le32() instead of > put_user(). A read into a buffer that can't be written used to report > success. It fails with -EFAULT now. A page holds all of the config > space, so a single read of it still works, libpci treats a short read as > an error. >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261104-work-procf= s-drivers-v2-0-245e54e87116@kernel.org?part=3D4