From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795069301; b=mKNFkN3h+mNyJ+vI9zRptGFpGLkWQdVidO6INjSacV9jTeD8Jgjl83u+iRG+loY4QeGe 686tqmHDMLYQyHWOLZQINjaOHk3QHU1+YMNmb8tXCHEYtBXD9+ChMbo9LBodail0x+inv 3wRQB/u9d8Vj0E+z5WQMrOn0HJVjNM/KjiKJksc3ywqmJLiwLuIYYihnnx1TnX26Ux5sR viSr3FK2f/meGgKpnZ1T/0L4S84y+j5RRl0Rb5+tMlnZkF3PtDFYf1l9RRODqJoz5j0nw FRWpZROHJ7YTuz8T2h43YzOvC+LcIAftQBXKGWlr4ntc4ZVish+Lr9c4Ax2xL6g69cQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795069301; h=DMARC-Filter:Received:Received:DKIM-Signature:Message-ID:From: Subject:Reply-To:To:Cc:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:Date; bh=AriJadNSG2kNLT0g5wkctcMWz1vv7s2SwXN26U9rybA=; b=z6016IRDjpf4bUxDHHfto13K2GZFDAxwA97T8+fjLSo87LIf8K5rYKBvSHebCRDjmdpK B33xj7Np1Te62GOIjCkbWdrCXhxHFCPb6S3LCL9pf/BGyTyuZ7vx0NEQjtD7iQ/2+ny+a dQ6KHtcaElONIaGFCviAdm3GAWbqdFn9LYDg99dS04lU9yRlZrvT57uxzB8CdEnIThawE zn6zAK9Mg6ycvQPFwwqz4XXznSrIziNmQpQS9BA7UiNLB+kTYQduCmA6/DXqDrEPZ5xW9 w4uRdfEEijRUAyRboFnno9YL1PAsNTIutfuD6OMsfnC4DAvx/zlxagP+b9WlGywje/g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cPVXEORV; arc=none smtp.remote-ip=172.234.252.31 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E301B606A337 for ; Thu, 19 Nov 2026 06:21:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E301B606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=cPVXEORV Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7405F4392F; Thu, 19 Nov 2026 06:21:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 701831F000C4; Thu, 19 Nov 2026 06:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795069300; bh=AriJadNSG2kNLT0g5wkctcMWz1vv7s2SwXN26U9rybA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cPVXEORVfoKfE4hqfzqMZ5/v6aVOKnkqC9RQU2F6G8V1zWVCVXzIHG5dUYo0ZmZg9 XjICuQcxUWyfXx9igNhR9lYp2xcNv1nFkOzaKbdxNWu3mS5KF+IAxbcBKoSYlcLvV9 R2uHTrqBbN1Zf/ro2J0cVS+sSd2y85b0uvG0x8O4m2x98cjJkV+Xxi/WTY92ACuFNQ Nb2D6cDqkMjwrk1+E4DKVk+ckIIdPZkgjXDk7sWj1axvGL60xbZXLgQV8DgXSWaXA0 NJbhBiYrHxFvGHfRiT5pMy/nsRxqUznrEyE9brA58EKFW2vXMumyRabBuAJpa+EM2o yo/LHncp7L1Fw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/2] arch, kexec: declare kexec and crash capabilities in Kconfig.kexec Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?TWlrZSBSYXBvcG9ydCAoTWljcm9zb2Z0KQ==?= , "Albert Ou" , "Alexander Gordeev" , "Andrew Morton" , "Baoquan He" , "Borislav Petkov" , "Catalin Marinas" , "Dave Hansen" , "Geert Uytterhoeven" , "Heiko Carstens" , "Helge Deller" , "Huacai Chen" , "Ingo Molnar" , "James E.J. Bottomley" , "John Paul Adrian Glaubitz" , "Madhavan Srinivasan" , "Palmer Dabbelt" , "Pasha Tatashin" , "Paul Walmsley" , "Pratyush Yadav" , "Rich Felker" , "Russell King" , "Thomas Bogendoerfer" , "Thomas Gleixner" , "Vasily Gorbik" , "Will Deacon" , "Yoshinori Sato" , x86@kernel.org Cc: "Alexandre Ghiti" , "Christian Borntraeger" , =?utf-8?b?Q2hyaXN0b3BoZSBMZXJveSAoQ1MgR1JPVVAp?= , "Cong Wang" , "Mark Rutland" , "Michael Ellerman" , "Nicholas Piggin" , "H. Peter Anvin" , =?utf-8?b?Uml0ZXNoIEhhcmphbmkgKElCTSk=?= , "Shrikanth Hegde" , "Sven Schnelle" , "WANG Xuerui" , kexec@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org In-Reply-To: <20261119-arch-kconfig-v1-2-37c276fe4d26@kernel.org> References: <20261119-arch-kconfig-v1-0-37c276fe4d26@kernel.org> <20261119-arch-kconfig-v1-2-37c276fe4d26@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Nov 2026 06:21:38 +0000 X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found no new issues in this patch, but noticed 1 related pre-existing issue it does not introduce: - [High] riscv: missing ARCH_KEEP_MEMBLOCK and HOTPLUG_CPU selects for KEXEC_FILE [1] -- commit 72fcff7ceb4b8dc27b8490a2ed5edc55973e96f8 Author: Mike Rapoport (Microsoft) arch, kexec: declare kexec and crash capabilities in Kconfig.kexec This commit moves the architecture capability options for kexec and crash dumps into kernel/Kconfig.kexec and updates each architecture to select them. > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index e7891a2a89da6..3fc73c99d06f1 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig [ ... ] > @@ -65,9 +67,14 @@ config RISCV > select ARCH_STACKWALK > select ARCH_SUPPORTS_ATOMIC_RMW > select ARCH_SUPPORTS_CFI > + select ARCH_SUPPORTS_CRASH_DUMP > + select ARCH_SUPPORTS_CRASH_HOTPLUG > select ARCH_SUPPORTS_DEBUG_PAGEALLOC if MMU > select ARCH_SUPPORTS_HUGE_PFNMAP if TRANSPARENT_HUGEPAGE > select ARCH_SUPPORTS_HUGETLBFS if MMU > + select ARCH_SUPPORTS_KEXEC > + select ARCH_SUPPORTS_KEXEC_FILE if 64BIT > + select ARCH_SUPPORTS_KEXEC_PURGATORY if 64BIT > select ARCH_SUPPORTS_LTO_CLANG if CMODEL_MEDANY > select ARCH_SUPPORTS_LTO_CLANG_THIN > select ARCH_SUPPORTS_MSEAL_SYSTEM_MAPPINGS if 64BIT && MMU > @@ -1105,38 +1112,17 @@ config RISCV_BOOT_SPINWAIT > =20 > If unsure what to do here, say N. > =20 > -config ARCH_SUPPORTS_KEXEC > - def_bool y > - > config ARCH_SELECTS_KEXEC > def_bool y > depends on KEXEC > select HOTPLUG_CPU if SMP > =20 > -config ARCH_SUPPORTS_KEXEC_FILE > - def_bool 64BIT > - > config ARCH_SELECTS_KEXEC_FILE > def_bool y > depends on KEXEC_FILE > select HAVE_IMA_KEXEC if IMA > select KEXEC_ELF [Severity: High] This problem wasn't introduced by this patch, but should KEXEC_FILE (or KEXEC_CORE) also select ARCH_KEEP_MEMBLOCK and HOTPLUG_CPU if SMP [1]? config RISCV only has "select ARCH_KEEP_MEMBLOCK if ACPI || KEXEC", and only ARCH_SELECTS_KEXEC selects HOTPLUG_CPU if SMP. When KEXEC_FILE=3Dy and KEXEC=3Dn: - Without ACPI, memblock_discard() frees the reserved regions array before reserve_memblock_reserved_regions() registers them in iomem_resource, so kexec_file_load() can place kexec segments over reserved memory. - On SMP without another option enabling HOTPLUG_CPU, smp_shutdown_nonboot_cpus() in machine_shutdown() and cpu_ops_sbi.cpu_stop are compiled out, leaving secondary harts running in the old kernel during kernel_kexec(). [1] https://sashiko.dev/#/bug/linux-78e86ad1-8753-462c-a044-1d3b3f2cab21 --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261119-arch-kconf= ig-v1-0-37c276fe4d26@kernel.org?part=3D2