Re: [PATCH] scripts/LinuxManBook/gropdf: use symlink instead of hard coded groff version

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1501 bytes --]

On 2023-08-07 03:16, Brian Inglis wrote:
> man-pages custom script gropdf has hard coded groff version used in font path
> groff provides symlink current for version to avoid the issue; use it in gropdf
> specify failing font path used to open font description file in error message
> 
> Signed-off-by: Brian Inglis <Brian.Inglis@Shaw.ca>

Hi Brian!

Please CC Deri, as he's the author, and will be able to review better than I can.

Thanks,
Alex

> ---
>  scripts/LinuxManBook/gropdf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/LinuxManBook/gropdf b/scripts/LinuxManBook/gropdf
> index 8474e583f57d..fb205395015b 100755
> --- a/scripts/LinuxManBook/gropdf
> +++ b/scripts/LinuxManBook/gropdf
> @@ -58,8 +58,8 @@ else
>  
>  my %cfg;
>  
> -$cfg{GROFF_VERSION}='1.22.4';
> -$cfg{GROFF_FONT_PATH}='/usr/share/groff/site-font:/usr/share/groff/1.22.4/font:/usr/lib/font';
> +$cfg{GROFF_VERSION}='current';
> +$cfg{GROFF_FONT_PATH}="/usr/share/groff/site-font:/usr/share/groff/$cfg{GROFF_VERSION}/font:/usr/lib/font";
>  $cfg{RT_SEP}=':';
>  binmode(STDOUT);
>  
> @@ -690,7 +690,7 @@ sub LoadDesc
>      my $f;
>  
>      OpenFile(\$f,$fontdir,"DESC");
> -    Msg(1,"Failed to open 'DESC'") if !defined($f);
> +    Msg(1,"Failed to open 'DESC' in '$fontdir'") if !defined($f);
>  
>      while (<$f>)
>      {

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]