public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: mtk.manpages@gmail.com
Cc: libc-alpha@sourceware.org, linux-man@vger.kernel.org,
	Ciprian Dorin Craciun <ciprian.craciun@gmail.com>,
	Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] system.3: Document bug and workaround when the command name starts with a hypen
Date: Mon, 4 Jan 2021 21:02:03 +0100	[thread overview]
Message-ID: <0d69b38d-2dc0-31ca-1218-c5483bf507b7@gmail.com> (raw)
In-Reply-To: <5c64d9f9-5bef-ba6a-ac7c-b119ce61d731@gmail.com>

D'oh

On 1/4/21 7:32 PM, Alejandro Colomar (man-pages) wrote:
> Hi Michael,
> 
> See a few corrections below.
> 
> Cheers,
> 
> Alex
> 
> On 1/4/21 7:04 PM, Alejandro Colomar wrote:
>> man-pages bug: 211029
>>  https://bugzilla.kernel.org/show_bug.cgi?id=211029
>>
>> Reported-by: Ciprian Dorin Craciun <ciprian.craciun@gmail.com>
>> Cc: Florian Weimer <fweimer@redhat.com>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>> ---
>>  man3/system.3 | 34 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>>
>> diff --git a/man3/system.3 b/man3/system.3
>> index aef40417a..0310d9a04 100644
>> --- a/man3/system.3
>> +++ b/man3/system.3
>> @@ -250,6 +250,40 @@ are not executed.
>>  Such risks are especially grave when using
>>  .BR system ()
>>  from a privileged program.
>> +.SH BUGS
>> +./" [BUG 211029](https://bugzilla.kernel.org/show_bug.cgi?id=211029)
>> +./" [Glibc bug](https://sourceware.org/bugzilla/show_bug.cgi?id=27143)
>> +./" [POSIX bug](https://www.austingroupbugs.net/view.php?id=1440)

s%/%\\%

>> +If the command name starts with a hyphen,
>> +.BR sh (1)
>> +interprets the command name as an option,
>> +and the behavior is undefined
>> +(See the
>> +.B \-c
>> +option in
> 
> option to
> 
>> +.BR sh (1).).
>> +To work around this problem,
>> +prepend the command with a space as below:
>> +.PP
>> +.RS 4
>> +.EX
>> +/* system_hyphen.c */
>> +
>> +#include <stdlib.h>
>> +
>> +int
>> +main(void)
>> +{
>> +    system(" -echo Hello world!");
> 
> \-echo
> 
>> +    exit(EXIT_SUCCESS);
>> +}
>> +.PP
>> +.RB "$" " sudo ln \-s \-T /usr/bin/echo /usr/bin/\-echo;"
>> +.RB "$" " cc \-o system_hyphen system_hyphen.c;"
>> +.RB "$" " ./system_hyphen;"
>> +Hello world!
>> +.EE
>> +.RE
>>  .SH SEE ALSO
>>  .BR sh (1),
>>  .BR execve (2),
>>
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

  reply	other threads:[~2021-01-04 20:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 15:13 [RFC] system.3: Document bug when the command name starts with a hypen Alejandro Colomar
2021-01-04 15:54 ` Ciprian Dorin Craciun
2021-01-04 18:04   ` [PATCH] system.3: Document bug and workaround " Alejandro Colomar
2021-01-04 18:32     ` Alejandro Colomar (man-pages)
2021-01-04 20:02       ` Alejandro Colomar (man-pages) [this message]
2021-01-08 14:15     ` [PATCH v2] " Alejandro Colomar
2021-01-08 14:20     ` [PATCH v3] " Alejandro Colomar
2021-01-08 14:22     ` [PATCH v4] " Alejandro Colomar
2021-01-08 14:28       ` Alejandro Colomar (man-pages)
2021-01-18 15:28         ` Ping: " Alejandro Colomar (man-pages)
2021-01-18 15:37           ` Michael Kerrisk (man-pages)
2021-01-18 15:45             ` Alejandro Colomar (man-pages)
2021-01-18 15:58               ` Michael Kerrisk (man-pages)
2021-01-18 16:11                 ` Alejandro Colomar (man-pages)
2021-01-18 15:36         ` Michael Kerrisk (man-pages)
2021-01-18 15:35       ` Michael Kerrisk (man-pages)
2021-01-05 13:23 ` [RFC] system.3: Document bug " Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d69b38d-2dc0-31ca-1218-c5483bf507b7@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=ciprian.craciun@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox