Re: make check failure with man-pages-6.04?

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 3144 bytes --]

Hey Sam!

On 4/5/23 02:49, Sam James wrote:
> 
> Sam James <sam@gentoo.org> writes:
> 
>> [[PGP Signed Part:Undecided]]
>> Hi all,
>>
>> Congratulations on the new release :)

:-)

>>
>> With `make check`, I get the following:

I expected issues like this from packagers :)
I'm doing the packaging for Debian and will have to disable it too.

>> ```
>> # make check
>> GREP    .tmp/man/man1/memusage.1.check-catman.touch
>> .tmp/man/man1/memusage.1.cat.grep:130:           Memory usage summary: heap total: 45200, heap peak: 6440, stack peak: 224
>> .tmp/man/man1/memusage.1.cat.grep:133:           realloc|        4044800             0  (nomove:40, dec:19, free:0)
>> make: *** [lib/check-catman.mk:36:
>> .tmp/man/man1/memusage.1.check-catman.touch] Error 1
>> ```
>>
>> I'll be honest and say I have no idea how to interpret this, if it
>> matters, or how to give more info (so let me know how if I need to!)

You can check what this is doing:


$ make check
GREP	.tmp/man/man1/memusage.1.check-catman.touch
.tmp/man/man1/memusage.1.cat.grep:130:           Memory usage summary: heap total: 45200, heap peak: 6440, stack peak: 224
.tmp/man/man1/memusage.1.cat.grep:133:           realloc|        40         44800             0  (nomove:40, dec:19, free:0)
make: *** [lib/check-catman.mk:36: .tmp/man/man1/memusage.1.check-catman.touch] Error 1
$ make help | grep variables
help-variables		Print all variables available, and their default values
$ make help-variables | grep verbose
V		Define to non-empty string for verbose output
$ make check V=1
GREP	.tmp/man/man1/memusage.1.check-catman.touch
! grep -n '.\{80\}.' .tmp/man/man1/memusage.1.cat.grep /dev/null >&2
.tmp/man/man1/memusage.1.cat.grep:130:           Memory usage summary: heap total: 45200, heap peak: 6440, stack peak: 224
.tmp/man/man1/memusage.1.cat.grep:133:           realloc|        40         44800             0  (nomove:40, dec:19, free:0)
make: *** [lib/check-catman.mk:36: .tmp/man/man1/memusage.1.check-catman.touch] Error 1


So the command that is acutally being run is:

! grep -n '.\{80\}.' .tmp/man/man1/memusage.1.cat.grep /dev/null >&2

Maybe it's still a bit criptic, but the 80 should be a hint to readers.
It's just checking that all pages fit within 80 columns.

> 
> Also, if you can't get to fixing it, that's no problem obviously, but
> it'd help a bunch if someone could let me know if this is severe or not

It depends on how severe you consider that some man pages don't fit in
80 columns :).  Nah, it's not a big issue, and it can be safely disabled.

I plan to reduce most of these warnings, but in some cases I don't think
I can fix them at all.

> - or if I can just disable tests temporarily in our packaging for now if
> it's not a big deal.

You can.  Maybe, though, you want to enable some test that works
reliably already (and which I'd be interested in being reported if it
starts failing):

$ make lint-man-tbl

> 
>>
>> best,
>> sam

Best,
Alex

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]