public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: mtk.manpages@gmail.com,
	Elvira Khabirova <lineprinter@altlinux.org>,
	linux-man@vger.kernel.org
Subject: Re: [PATCH] ptrace.2: document PTRACE_GET_SYSCALL_INFO
Date: Tue, 10 Sep 2019 12:51:55 +0200	[thread overview]
Message-ID: <0eb09cbc-8035-ee82-9c75-6525d91e7138@gmail.com> (raw)
In-Reply-To: <20190902123858.GA8956@altlinux.org>

Hello Dmitry,

On 9/2/19 2:38 PM, Dmitry V. Levin wrote:
> PTRACE_GET_SYSCALL_INFO request was introduced by Linux kernel commit
> 201766a20e30f982ccfe36bebfad9602c3ff574a aka v5.3-rc1~65^2~23.
> 
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
>  man2/ptrace.2 | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/man2/ptrace.2 b/man2/ptrace.2
> index 8b8daf238..3b774f87b 100644
> --- a/man2/ptrace.2
> +++ b/man2/ptrace.2
> @@ -1005,6 +1005,27 @@ of the
>  .IR "struct user_desc"
>  is ignored; in other words,
>  this ptrace operation can't be used to allocate a free TLS entry.)
> +.TP
> +.BR PTRACE_GET_SYSCALL_INFO " (since Linux 5.3)"
> +.\" commit 201766a20e30f982ccfe36bebfad9602c3ff574a
> +Retrieve information about the syscall that caused the stop.
> +The information is placed into the buffer pointed by
> +.I data
> +argument, which should be a pointer to a buffer of type
> +.IR "struct ptrace_syscall_info" .
> +The
> +.I addr
> +argument contains the size of the buffer pointed to
> +by
> +.I data
> +argument (i.e.,
> +.IR "sizeof(struct ptrace_syscall_info)" ).
> +The return value contains the number of bytes available
> +to be written by the kernel.
> +If the size of data to be written by the kernel exceeds the size
> +specified by
> +.I addr
> +argument, the output is truncated.
>  .\"
>  .SS Death under ptrace
>  When a (possibly multithreaded) process receives a killing signal

Thanks for this patch. I've applied, tweaked the wording very
slightly, and pushed.

However, this patch lacks an important piece: documentation of
'struct ptrace_syscall_info'. I could take a shot at this, but 
I see you already wrote a test program for this ptrace operation. 
Would you be willing to add a patch that documents the structure?

Thanks,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  reply	other threads:[~2019-09-10 10:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 12:38 [PATCH] ptrace.2: document PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2019-09-10 10:51 ` Michael Kerrisk (man-pages) [this message]
2019-09-11 17:38   ` [PATCH] ptrace.2: document struct ptrace_syscall_info Dmitry V. Levin
2019-09-12  9:17     ` Michael Kerrisk (man-pages)
2019-09-13 15:40       ` Dmitry V. Levin
2019-09-13 18:48         ` Michael Kerrisk (man-pages)
2019-09-13 19:37           ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0eb09cbc-8035-ee82-9c75-6525d91e7138@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=ldv@altlinux.org \
    --cc=lineprinter@altlinux.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox