Re: [PATCH 2/3] landlock.7: Document Landlock ABI v2 (file reparenting; kernel 5.19)

[Alex Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1610 bytes --]

Hi Mickaël,

On 2/22/23 08:36, Mickaël Salaün wrote:
> On 2023-02-21T21:50:22.000+01:00, Günther Noack wrote:
> 
> [...]
> 
>>   .SH VERSIONS
>> -Landlock was added in Linux 5.13.
>> +Landlock was introduced in Linux 5.13.
>> +.PP
>> +The availability of individual Landlock features is versioned through
>> +ABI levels:
>> +.TS
>> +box;
>> +ntb| ntb| lbx
>> +nt| nt| lbx.
>> +ABI	Kernel	Newly introduced access rights
>> +_	_	_
>> +1	5.13	LANDLOCK_ACCESS_FS_EXECUTE
>> +\^	\^	LANDLOCK_ACCESS_FS_WRITE_FILE
>> +\^	\^	LANDLOCK_ACCESS_FS_READ_FILE
>> +\^	\^	LANDLOCK_ACCESS_FS_READ_DIR
>> +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_DIR
>> +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_FILE
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_CHAR
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_DIR
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_REG
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SOCK
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_FIFO
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_BLOCK
>> +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SYM
>> +_	_	_
>> +2	5.19	LANDLOCK_ACCESS_FS_REFER
>> +.TE
>> +.PP
> 
> A line break would be nice here.

.PP should be performing a line break.  I didn't yet read the formatted 
version, so maybe there's something wrong with the table, but from 
inspection of the source it seems reasonable to me.

Cheers,

Alex

> 
>> +To query the running kernel's Landlock ABI level, programs may pass
> 
> s/level/version/
> 
>> +the
>> +.B LANDLOCK_CREATE_RULESET_VERSION
>> +flag to
>> +.BR landlock_create_ruleset (2).

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]