public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Michael Kerrisk <mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: "linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Ulrich Drepper <drepper-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: For review: timer_create.2
Date: Wed, 11 Feb 2009 09:30:30 +0100	[thread overview]
Message-ID: <1234341030.23438.109.camel@twins> (raw)
In-Reply-To: <1234340803.23438.107.camel@twins>

On Wed, 2009-02-11 at 09:26 +0100, Peter Zijlstra wrote:
> On Tue, 2009-02-10 at 14:53 +1300, Michael Kerrisk wrote:
> >        static void
> >        handler(int sig, siginfo_t *si, void *uc)
> >        {
> >            /* Note: calling printf() from a signal handler is not
> >               strictly correct, since printf() is not async-signal-safe;
> >               see signal(7) */
> > 
> >            printf("Caught signal %d\n", sig);
> >            print_siginfo(si);
> >            signal(SIG, SIG_IGN);
> >        }
> 
> Is that actually safe to do?
> 
> I can remember getting into deadlocks by doing this some few years ago.
> 
> The problem was that glibc uses a mutex to guard its memory area for the
> malloc memory pool, and signals can come in while the main thread of
> execution is within that mutex, if at that point the signal handler also
> tries to use anything using malloc (here, I was thinking printf()
> might), you've got a deadlock.
> 
> One thing I always enjoyed about the QNX man-pages was that it
> explicitly states which functions are and are _NOT_ signal safe, iow
> which functions can be reliably used from signal handler context.

Right, so maybe if I had read the comment this time... I'm so trained to
ignore comments in code :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-02-11  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10  1:53 For review: timer_create.2 Michael Kerrisk
     [not found] ` <4990DE09.7020801-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-02-11  8:26   ` Peter Zijlstra
2009-02-11  8:30     ` Peter Zijlstra [this message]
2009-02-11  8:39     ` Michael Kerrisk
2009-02-11  8:34   ` Peter Zijlstra
2009-02-11  8:42     ` Michael Kerrisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234341030.23438.109.camel@twins \
    --to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=drepper-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox