public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] epoll_wait.2: Clarify that the timeout is measured against CLOCK_MONOTONIC
@ 2016-09-15  9:17 Mike Crowe
       [not found] ` <1473931073-26587-1-git-send-email-mac-6JwzNyXSCK3QT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Crowe @ 2016-09-15  9:17 UTC (permalink / raw)
  To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w
  Cc: linux-man-u79uwXL29TY76Z2rM5mHXA, Mike Crowe

The existing page left the choice of clock as ambiguous. My reading of the
kernel implementation is that CLOCK_MONOTONIC is always used since ep_poll
calls schedule_hrtimeout_range, which calls schedule_hrtimeout_range_clock
passing CLOCK_MONOTONIC.

References:
 http://lxr.free-electrons.com/source/fs/eventpoll.c?v=4.7#L1614
 http://lxr.free-electrons.com/source/kernel/time/hrtimer.c?v=4.7#L1785

The "measured against" terminology was borrowed from nanosleep.2.

I've checked all the way back to Linux v2.6.12 where the calculation was
done using jiffies so I think that this has effectively always been true.

Signed-off-by: Mike Crowe <mac-6JwzNyXSCK3QT0dZR+AlfA@public.gmane.org>
---
 man2/epoll_wait.2 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/man2/epoll_wait.2 b/man2/epoll_wait.2
index 9637906..48bb281 100644
--- a/man2/epoll_wait.2
+++ b/man2/epoll_wait.2
@@ -55,6 +55,9 @@ The
 argument specifies the number of milliseconds that
 .BR epoll_wait ()
 will block.
+Time is measured against the
+.B CLOCK_MONOTONIC
+clock.
 The call will block until either:
 .IP * 3
 a file descriptor delivers an event;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] epoll_wait.2: Clarify that the timeout is measured against CLOCK_MONOTONIC
       [not found] ` <1473931073-26587-1-git-send-email-mac-6JwzNyXSCK3QT0dZR+AlfA@public.gmane.org>
@ 2016-09-20 12:33   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2016-09-20 12:33 UTC (permalink / raw)
  To: Mike Crowe
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
	linux-man-u79uwXL29TY76Z2rM5mHXA

On 09/15/2016 11:17 AM, Mike Crowe wrote:
> The existing page left the choice of clock as ambiguous. My reading of the
> kernel implementation is that CLOCK_MONOTONIC is always used since ep_poll
> calls schedule_hrtimeout_range, which calls schedule_hrtimeout_range_clock
> passing CLOCK_MONOTONIC.
> 
> References:
>  http://lxr.free-electrons.com/source/fs/eventpoll.c?v=4.7#L1614
>  http://lxr.free-electrons.com/source/kernel/time/hrtimer.c?v=4.7#L1785
> 
> The "measured against" terminology was borrowed from nanosleep.2.
> 
> I've checked all the way back to Linux v2.6.12 where the calculation was
> done using jiffies so I think that this has effectively always been true.

Thanks, Mike. I've applied this patch.

Cheers,

Michael

> Signed-off-by: Mike Crowe <mac-6JwzNyXSCK3QT0dZR+AlfA@public.gmane.org>
> ---
>  man2/epoll_wait.2 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/man2/epoll_wait.2 b/man2/epoll_wait.2
> index 9637906..48bb281 100644
> --- a/man2/epoll_wait.2
> +++ b/man2/epoll_wait.2
> @@ -55,6 +55,9 @@ The
>  argument specifies the number of milliseconds that
>  .BR epoll_wait ()
>  will block.
> +Time is measured against the
> +.B CLOCK_MONOTONIC
> +clock.
>  The call will block until either:
>  .IP * 3
>  a file descriptor delivers an event;
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-20 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15  9:17 [PATCH] epoll_wait.2: Clarify that the timeout is measured against CLOCK_MONOTONIC Mike Crowe
     [not found] ` <1473931073-26587-1-git-send-email-mac-6JwzNyXSCK3QT0dZR+AlfA@public.gmane.org>
2016-09-20 12:33   ` Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox