[PATCH] io_getevents.2: Add EINVAL for case of timeout parameter out of range

[PATCH] io_getevents.2: Add EINVAL for case of timeout parameter out of range

[zhangyi (F)]

io_[p]getevents syscall should return -EINVAL if timeout is out of
range, update description of this error return value.

Link: https://lore.kernel.org/lkml/1564451504-27906-1-git-send-email-yi.zhang@huawei.com/
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>
---
 man2/io_getevents.2 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/man2/io_getevents.2 b/man2/io_getevents.2
index 0eb4b385e..5560bb8ee 100644
--- a/man2/io_getevents.2
+++ b/man2/io_getevents.2
@@ -73,8 +73,9 @@ Interrupted by a signal handler; see
 .TP
 .B EINVAL
 \fIctx_id\fP is invalid.
-\fImin_nr\fP is out of range or \fInr\fP is
-out of range.
+\fImin_nr\fP is out of range or \fInr\fP is out of range, or
+\fItimeout\fP is out of range (\fItv_sec\fP was less than zero, or
+\fItv_nsec\fP was not less than 1,000,000,000).
 .TP
 .B ENOSYS
 .BR io_getevents ()
-- 
2.20.1

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

Re: [PATCH] io_getevents.2: Add EINVAL for case of timeout parameter out of range

[Michael Kerrisk (man-pages)]

Hello Zhangyi,

On Wed, 31 Jul 2019 at 04:57, zhangyi (F) <yi.zhang@huawei.com> wrote:
>
> io_[p]getevents syscall should return -EINVAL if timeout is out of
> range, update description of this error return value.
>
> Link: https://lore.kernel.org/lkml/1564451504-27906-1-git-send-email-yi.zhang@huawei.com/


It appears that the kernel patch to implement this check was never
merged. Do you know what happened to it?

Thanks,

Michael

> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
>  man2/io_getevents.2 | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/man2/io_getevents.2 b/man2/io_getevents.2
> index 0eb4b385e..5560bb8ee 100644
> --- a/man2/io_getevents.2
> +++ b/man2/io_getevents.2
> @@ -73,8 +73,9 @@ Interrupted by a signal handler; see
>  .TP
>  .B EINVAL
>  \fIctx_id\fP is invalid.
> -\fImin_nr\fP is out of range or \fInr\fP is
> -out of range.
> +\fImin_nr\fP is out of range or \fInr\fP is out of range, or
> +\fItimeout\fP is out of range (\fItv_sec\fP was less than zero, or
> +\fItv_nsec\fP was not less than 1,000,000,000).
>  .TP
>  .B ENOSYS
>  .BR io_getevents ()
> --
> 2.20.1
>


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH] io_getevents.2: Add EINVAL for case of timeout parameter out of range

[zhangyi (F)]

Hi, Michael.

On 2020/4/16 20:12, Michael Kerrisk (man-pages) wrote:
> Hello Zhangyi,
> 
> On Wed, 31 Jul 2019 at 04:57, zhangyi (F) <yi.zhang@huawei.com> wrote:
>>
>> io_[p]getevents syscall should return -EINVAL if timeout is out of
>> range, update description of this error return value.
>>
>> Link: https://lore.kernel.org/lkml/1564451504-27906-1-git-send-email-yi.zhang@huawei.com/
> 
> 
> It appears that the kernel patch to implement this check was never
> merged. Do you know what happened to it?
> 

I'm not sure why this patch was not merged and pinged it last mounth,
but there is no response.

https://www.spinics.net/lists/linux-fsdevel/msg164111.html

Hi, Al.

Any chance to apply below kernel patch?
https://lore.kernel.org/lkml/1564451504-27906-1-git-send-email-yi.zhang@huawei.com/

Thanks,
Yi.

>> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
>> Cc: Jeff Moyer <jmoyer@redhat.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Deepa Dinamani <deepa.kernel@gmail.com>
>> ---
>>  man2/io_getevents.2 | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/man2/io_getevents.2 b/man2/io_getevents.2
>> index 0eb4b385e..5560bb8ee 100644
>> --- a/man2/io_getevents.2
>> +++ b/man2/io_getevents.2
>> @@ -73,8 +73,9 @@ Interrupted by a signal handler; see
>>  .TP
>>  .B EINVAL
>>  \fIctx_id\fP is invalid.
>> -\fImin_nr\fP is out of range or \fInr\fP is
>> -out of range.
>> +\fImin_nr\fP is out of range or \fInr\fP is out of range, or
>> +\fItimeout\fP is out of range (\fItv_sec\fP was less than zero, or
>> +\fItv_nsec\fP was not less than 1,000,000,000).
>>  .TP
>>  .B ENOSYS
>>  .BR io_getevents ()
>> --
>> 2.20.1
>>
> 
>