Re: [PATCH v2 3/4] tm.3type: describe tm_zone, tm_gmtoff

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1320 bytes --]

On 7/19/22 17:35, наб wrote:
> ---
>   man3/tm.3type | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
> 
> diff --git a/man3/tm.3type b/man3/tm.3type
> index 78e05a41a..e7e39cc5c 100644
> --- a/man3/tm.3type
> +++ b/man3/tm.3type
[...]
> @@ -48,10 +76,30 @@ in C99.
>   .SH CONFORMING TO
>   C90 and later;
>   POSIX.1-2001 and later.
> +.PP
> +.IR tm_gmtoff " and " tm_zone

I prefer one identifier per line:

.I foo
and
.I bar

> +originate from 4.3BSD-Tahoe (where
> +.I tm_zone
> +is a
> +.IR "char *" ).
>   .SH NOTES
>   .I tm_sec
>   can represent a leap second with the value
>   .BR 60 .
> +.PP
> +.BR timezone (3),
> +as a variable, is an XSI extension: some systems provide the V7-compatible
> +.\" FreeBSD
> +.BR timezone ()
> +function.
> +The
> +.I tm_gmtoff
> +field provides an alternative (with the opposite sign) for those systems.
> +.PP
> +.I tm_zone
> +points to static storage and may be overriden on subsequent calls to
> +.BR localtime (3)
> +and similar functions (this, however, never happens under glibc).

If you reorder it, you can remove a coma:

however, this never ...

>   .SH SEE ALSO
>   .BR ctime (3),
>   .BR strftime (3),

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]