Re: [LTP] ltp getdents syscalls testcases and 2.6.27-rcX

Daniel Gollub
2008-09-25T09:17:30Z

On Thursday 25 September 2008 10:08:28 Garrett Cooper wrote:
> >> Yes, it is. There are numerous test cases in LTP which use:
> >>         struct dirent,
> >> by including /usr/include/dirent.h. The interesting part is, this guy
> >> (/usr/include/dirent.h) in turn includes /usr/include/bits/dirent.h,
> >> where the definition of struct resides. Following is the patch which
> >> solves this issue along with page.h header file removal from 2.6.25
> >> onwards, reported by Garret earlier.

^^^^^^^^^

> >
> > Tried the patch - ltp build with 2.6.27-rc linux headers sucessfully.
> > Thanks for the info and the patch!
> >
> > Btw. man pages need to get also updated ... there are some pages which
> > still mention <linux/dirent.h>.
> >
> > Garret, with 2.6.25 <asm/page.h> got removed - right?
> > If so swapon(2) man page needs also get fixed:
> >
> > dgollub@marvin:~/projects/man-pages> grep -r "asm\/page.h" *
> > man2/swapon.2:.B #include <asm/page.h>     /* to find PAGE_SIZE */
> >
> > best regards,
> > Daniel
> >
> > ---
> >
[...]

> I find it interesting because I honestly don't remember mentioning this
> :D..
>
> Would you perhaps mean linux/signalfd.h vs sys/signalfd.h?

I don't know either - i was just refering to Subrata's reply...
Anyway, asm/page.h is really gone:

commit ed7b1889da256977574663689b598d88950bbd23
Author: Kirill A. Shutemov <k.shutemov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu Feb 7 00:15:56 2008 -0800

Unexport asm/page.h

Do not export asm/page.h during make headers_install. This removes
PAGE_SIZE
from userspace headers.

Garret, just to refresh your memory ..... ;)
http://article.gmane.org/gmane.linux.ltp/4873

best regards,
Daniel

---

diff --git a/man2/swapon.2 b/man2/swapon.2
index 4c7008a..2a22be7 100644
--- a/man2/swapon.2
+++ b/man2/swapon.2
@@ -40,8 +40,6 @@ swapon, swapoff \- start/stop swapping to file/device
.SH SYNOPSIS
.B #include <unistd.h>
.br
-.B #include <asm/page.h> /* to find PAGE_SIZE */
-.br
.B #include <sys/swap.h>
.sp
.BI "int swapon(const char *" path ", int " swapflags );