[PATCH] mount.2 : Add MS_SILENT mountflag

[PATCH] mount.2 : Add MS_SILENT mountflag

[Maxin John]

Dear Michael,

 The MS_VERBOSE in mountflags option of mount system call was replaced
by MS_SILENT in Kernel version 2.6.17
(http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b04c997b1120feefa1e6ee8e2902270bc055cd2
).

The LKML thread regarding this commit:
http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-03/msg08081.html

eg:
mount("/dev/sda1", "/mnt/test", "ext3", MS_SILENT, "");

The patch also includes some miscellaneous cleanups of the mount.2 man page.

Kindly let me know if there are any issues with respect to this patch.

Cheers,

Maxin B. John
Sony India Software Center
Bangalore, India

Signed-off-by: Maxin B. John <maxin.john-qujY0cBTTHtBDgjK7y7TUQ@public.gmane.org>
-------

diff -uNr man-pages-3.10/man2/mount.2 man-pages-3.10_mount/man2/mount.2
--- man-pages-3.10/man2/mount.2	2008-09-23 19:22:25.000000000 +0530
+++ man-pages-3.10_mount/man2/mount.2	2008-09-30 17:15:29.087697160 +0530
@@ -128,7 +128,6 @@
 Since Linux 2.6.26, the
 .B MS_RDONLY
 flag is honored when making a bind mount.
-Since Linux 2.6.2
 .TP
 .BR MS_DIRSYNC " (since Linux 2.5.19)"
 Make directory changes on this file system synchronous.
@@ -228,6 +227,9 @@
 .BR MS_NODEV ,
 .BR MS_NOEXEC .
 .TP
+.B MS_SILENT " (Linux 2.6.17 onwards)"
+This flag suppresses the display of verbose messages.
+.TP
 .B MS_SYNCHRONOUS
 Make writes on this file system synchronous (as though
 the

-------
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mount.2 : Add MS_SILENT mountflag

[Michael Kerrisk]

Hello Maxin

(Ted, your input would be welcome below.)

On Tue, Sep 30, 2008 at 1:53 PM, Maxin John <maxin.john-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Dear Michael,
>
>  The MS_VERBOSE in mountflags option of mount system call was replaced
> by MS_SILENT in Kernel version 2.6.17
> (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b04c997b1120feefa1e6ee8e2902270bc055cd2
> ).
>
> The LKML thread regarding this commit:
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-03/msg08081.html
>
> eg:
> mount("/dev/sda1", "/mnt/test", "ext3", MS_SILENT, "");
>
> The patch also includes some miscellaneous cleanups of the mount.2 man page.
>
> Kindly let me know if there are any issues with respect to this patch.
>
> Cheers,
>
> Maxin B. John
> Sony India Software Center
> Bangalore, India
>
> Signed-off-by: Maxin B. John <maxin.john-qujY0cBTTHtBDgjK7y7TUQ@public.gmane.org>
> -------
>
> diff -uNr man-pages-3.10/man2/mount.2 man-pages-3.10_mount/man2/mount.2
> --- man-pages-3.10/man2/mount.2 2008-09-23 19:22:25.000000000 +0530
> +++ man-pages-3.10_mount/man2/mount.2   2008-09-30 17:15:29.087697160 +0530
> @@ -128,7 +128,6 @@
>  Since Linux 2.6.26, the
>  .B MS_RDONLY
>  flag is honored when making a bind mount.
> -Since Linux 2.6.2
>  .TP
>  .BR MS_DIRSYNC " (since Linux 2.5.19)"
>  Make directory changes on this file system synchronous.
> @@ -228,6 +227,9 @@
>  .BR MS_NODEV ,
>  .BR MS_NOEXEC .
>  .TP
> +.B MS_SILENT " (Linux 2.6.17 onwards)"
> +This flag suppresses the display of verbose messages.
> +.TP

I've rewritten and expanded this somewhat, making it:

       MS_SILENT (since Linux 2.6.17)
              Suppress the display of certain (printk()) warning
              messages  in the kernel log.  This flag supersedes
              the misnamed and obsolete MS_VERBOSE flag  (avail-
              able since Linux 2.4.12), which has the same mean-
              ing.

Does that seem okay to the two of you?

Cheers,

Michael
-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mount.2 : Add MS_SILENT mountflag

[Maxin John]

Dear Michael,

      I do welcome that modification as this provides more clarity.

Thanks and Regards,

Maxin B. John
Sony India Software Center
Bangalore, India


On Wed, Oct 1, 2008 at 6:51 PM, Michael Kerrisk
<mtk.manpages-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:
> Hello Maxin
>
> (Ted, your input would be welcome below.)
>
> On Tue, Sep 30, 2008 at 1:53 PM, Maxin John <maxin.john-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Dear Michael,
>>
>>  The MS_VERBOSE in mountflags option of mount system call was replaced
>> by MS_SILENT in Kernel version 2.6.17
>> (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b04c997b1120feefa1e6ee8e2902270bc055cd2
>> ).
>>
>> The LKML thread regarding this commit:
>> http://linux.derkeiler.com/Mailing-Lists/Kernel/2006-03/msg08081.html
>>
>> eg:
>> mount("/dev/sda1", "/mnt/test", "ext3", MS_SILENT, "");
>>
>> The patch also includes some miscellaneous cleanups of the mount.2 man page.
>>
>> Kindly let me know if there are any issues with respect to this patch.
>>
>> Cheers,
>>
>> Maxin B. John
>> Sony India Software Center
>> Bangalore, India
>>
>> Signed-off-by: Maxin B. John <maxin.john-qujY0cBTTHtBDgjK7y7TUQ@public.gmane.org>
>> -------
>>
>> diff -uNr man-pages-3.10/man2/mount.2 man-pages-3.10_mount/man2/mount.2
>> --- man-pages-3.10/man2/mount.2 2008-09-23 19:22:25.000000000 +0530
>> +++ man-pages-3.10_mount/man2/mount.2   2008-09-30 17:15:29.087697160 +0530
>> @@ -128,7 +128,6 @@
>>  Since Linux 2.6.26, the
>>  .B MS_RDONLY
>>  flag is honored when making a bind mount.
>> -Since Linux 2.6.2
>>  .TP
>>  .BR MS_DIRSYNC " (since Linux 2.5.19)"
>>  Make directory changes on this file system synchronous.
>> @@ -228,6 +227,9 @@
>>  .BR MS_NODEV ,
>>  .BR MS_NOEXEC .
>>  .TP
>> +.B MS_SILENT " (Linux 2.6.17 onwards)"
>> +This flag suppresses the display of verbose messages.
>> +.TP
>
> I've rewritten and expanded this somewhat, making it:
>
>       MS_SILENT (since Linux 2.6.17)
>              Suppress the display of certain (printk()) warning
>              messages  in the kernel log.  This flag supersedes
>              the misnamed and obsolete MS_VERBOSE flag  (avail-
>              able since Linux 2.4.12), which has the same mean-
>              ing.
>
> Does that seem okay to the two of you?
>
> Cheers,
>
> Michael
> --
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
> man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
> Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mount.2 : Add MS_SILENT mountflag

[Theodore Tso]

On Wed, Oct 01, 2008 at 03:21:27PM +0200, Michael Kerrisk wrote:
> (Ted, your input would be welcome below.)
> 
>
> I've rewritten and expanded this somewhat, making it:
> 
>        MS_SILENT (since Linux 2.6.17)
>               Suppress the display of certain (printk()) warning
>               messages  in the kernel log.  This flag supersedes
>               the misnamed and obsolete MS_VERBOSE flag  (avail-
>               able since Linux 2.4.12), which has the same mean-
>               ing.
> 
> Does that seem okay to the two of you?

Looks good to me!

Acked-by: "Theodore Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html