public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Baudis <pasky-AlSwsSmVLrQ@public.gmane.org>
To: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] printf.3: Add a note about sprintf(s, "%s", s)
Date: Fri, 19 Dec 2008 18:37:33 +0100	[thread overview]
Message-ID: <20081219173733.GC13134@machine.or.cz> (raw)
In-Reply-To: <cfd18e0f0812190857k187ca48ct9ee6da3b0c5a9e06-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

  Hi,

On Fri, Dec 19, 2008 at 11:57:05AM -0500, Michael Kerrisk wrote:
> I agree that there's a problem with the page, but I don't think this
> patch is sufficient, nor does is it made in quite the right place.
> (This isn't a point that relates specifically to "%s", but rather to
> the *s*printf() functions.)
> 
> I made a much bigger change that goes into more detail.  The patch,
> destined for 3.16, is shown below.  Does it look okay to you?

  I agree that it is better. Just out of curiosity, can you think of any
other conversions than %s that would cause this? Maybe I missed
something obvious but I could not think of anything.

-- 
				Petr "Pasky" Baudis
The average, healthy, well-adjusted adult gets up at seven-thirty
in the morning feeling just terrible. -- Jean Kerr
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-12-19 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-07 23:37 [PATCH] printf.3: Add a note about sprintf(s, "%s", s) Petr Baudis
     [not found] ` <20081207233721.GN10491-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
2008-12-19 16:57   ` Michael Kerrisk
     [not found]     ` <cfd18e0f0812190857k187ca48ct9ee6da3b0c5a9e06-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-19 17:37       ` Petr Baudis [this message]
     [not found]         ` <20081219173733.GC13134-DDGJ70k9y3lX+M3pkMnKjw@public.gmane.org>
2008-12-19 18:38           ` Michael Kerrisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081219173733.GC13134@machine.or.cz \
    --to=pasky-alswssmvlrq@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox