[patch] send.2, recv.2: Fixed type of msg_controllen in struct msghdr

[patch] send.2, recv.2: Fixed type of msg_controllen in struct msghdr

[Nicholas Hunt]

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

Hello, 

This patch fixes the type of msg_controllen in the struct msghdr
definition given in send.2 and recv.2 to match the definition in glibc
and the kernel. Applies cleanly to the current head of git (sha hash:
55d56b71...).

-Nick

diff --git a/man2/recv.2 b/man2/recv.2
index 9431b5c..d5eaf33 100644
--- a/man2/recv.2
+++ b/man2/recv.2
@@ -304,7 +304,7 @@ struct msghdr {
     struct iovec *msg_iov;        /* scatter/gather array */
     size_t        msg_iovlen;     /* # elements in msg_iov */
     void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */
     int           msg_flags;      /* flags on received message */
 };
 .fi
diff --git a/man2/send.2 b/man2/send.2
index c99b77a..c9e76b0 100644
--- a/man2/send.2
+++ b/man2/send.2
@@ -250,7 +250,7 @@ struct msghdr {
     struct iovec *msg_iov;        /* scatter/gather array */
     size_t        msg_iovlen;     /* # elements in msg_iov */
     void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */
     int           msg_flags;      /* flags on received message */
 };
 .fi

-- 
Computer Science and Engineering, University of Washington
E-mail   : nhunt-GmWTxIRN22iJaUV4rX00uodd74u8MsAO@public.gmane.org
PGP Key  : http://students.washington.edu/nhunt/cs.asc

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [patch] send.2, recv.2: Fixed type of msg_controllen in struct msghdr

[Michael Kerrisk]

Hello Nicholas,

On Thu, Aug 19, 2010 at 3:13 AM, Nicholas Hunt <nhunt-GmWTxIRN22iJaUV4rX00uodd74u8MsAO@public.gmane.org> wrote:
> Hello,
>
> This patch fixes the type of msg_controllen in the struct msghdr
> definition given in send.2 and recv.2 to match the definition in glibc
> and the kernel. Applies cleanly to the current head of git (sha hash:
> 55d56b71...).

This was already a know issue, see
http://sourceware.org/bugzilla/show_bug.cgi?id=2448
See also the NOTES on each page.

However, your patch is probably still a good idea. I applied it for
man-pages 2.26.

Thanks,

Michael



> -Nick
>
> diff --git a/man2/recv.2 b/man2/recv.2
> index 9431b5c..d5eaf33 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -304,7 +304,7 @@ struct msghdr {
>     struct iovec *msg_iov;        /* scatter/gather array */
>     size_t        msg_iovlen;     /* # elements in msg_iov */
>     void         *msg_control;    /* ancillary data, see below */
> -    socklen_t     msg_controllen; /* ancillary data buffer len */
> +    size_t        msg_controllen; /* ancillary data buffer len */
>     int           msg_flags;      /* flags on received message */
>  };
>  .fi
> diff --git a/man2/send.2 b/man2/send.2
> index c99b77a..c9e76b0 100644
> --- a/man2/send.2
> +++ b/man2/send.2
> @@ -250,7 +250,7 @@ struct msghdr {
>     struct iovec *msg_iov;        /* scatter/gather array */
>     size_t        msg_iovlen;     /* # elements in msg_iov */
>     void         *msg_control;    /* ancillary data, see below */
> -    socklen_t     msg_controllen; /* ancillary data buffer len */
> +    size_t        msg_controllen; /* ancillary data buffer len */
>     int           msg_flags;      /* flags on received message */
>  };
>  .fi
>
> --
> Computer Science and Engineering, University of Washington
> E-mail   : nhunt-GmWTxIRN22iJaUV4rX00uodd74u8MsAO@public.gmane.org
> PGP Key  : http://students.washington.edu/nhunt/cs.asc
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface" http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html