getifaddrs: Prevent possible NULL pointer access

getifaddrs: Prevent possible NULL pointer access

[Thomas Jarosch]

[-- Attachment #1: Type: Text/Plain, Size: 172 bytes --]

Hello,

the example code for getifaddrs() contains a possible NULL pointer access.
Attached is a patch against man-pages 3.22 from Fedora 12.

Best regards,
Thomas Jarosch

[-- Attachment #2: man-pages-getifaddrs-prevent-NULL-access.patch --]
[-- Type: text/x-patch, Size: 561 bytes --]

diff -u -r -p man-pages-3.22/man3/getifaddrs.3 man-pages.prevent_NULL/man3/getifaddrs.3
--- man-pages-3.22/man3/getifaddrs.3	2009-07-25 08:53:32.000000000 +0200
+++ man-pages.prevent_NULL/man3/getifaddrs.3	2010-10-05 14:13:25.536917362 +0200
@@ -245,6 +245,9 @@ main(int argc, char *argv[])
        can free list later */
 
     for (ifa = ifaddr; ifa != NULL; ifa = ifa\->ifa_next) {
+        if (ifa\->ifa_addr == NULL)
+            continue;
+
         family = ifa\->ifa_addr\->sa_family;
 
         /* Display interface name and family (including symbolic

Re: getifaddrs: Prevent possible NULL pointer access

[Michael Kerrisk]

On Tue, Oct 5, 2010 at 2:57 PM, Thomas Jarosch
<thomas.jarosch-XXsH3GEs1jrby3iVrkZq2A@public.gmane.org> wrote:
> Hello,
>
> the example code for getifaddrs() contains a possible NULL pointer access.
> Attached is a patch against man-pages 3.22 from Fedora 12.

Thanks Thomas. Applied for man-pages 3.29.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface"; http://man7.org/tlpi/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html