public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Mark Kettenis
	<mark.kettenis-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>,
	Martin Ferrari <tincho-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>,
	Robert Edmonds <edmonds-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH/RFC] resolver_r.3: New page documenting res_ninit() et al
Date: Mon, 4 Jul 2011 00:33:31 -0500	[thread overview]
Message-ID: <20110704053331.GA16153@elie> (raw)
In-Reply-To: <20110704051737.GA15844@elie>

Hi again,

Jonathan Nieder wrote:

> --- /dev/null
> +++ b/man3/resolver_r.3
> @@ -0,0 +1,136 @@
[...]
> +.B typedef struct state *res_state;

Looking over [1], it occurs to me that treating "res_state" as an
opaque type doesn't work if this API is to be actually usable.  A
typical program will look like this:

	struct __res_state res;

	if (res_ninit(&res))
		die_errno("cannot initialize resolver");
	...

Is "struct __res_state" really supposed to be part of the public
API?  I guess it is.

So I'd suggest squashing in the mini-patch below to reflect that.
Sorry for the noise.

[1] https://lists.isc.org/pipermail/bind-users/2008-July/070847.html

Signed-off-by: Jonathan Nieder <jrnieder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 man3/resolver_r.3 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/man3/resolver_r.3 b/man3/resolver_r.3
index f2ced438..a70834b4 100644
--- a/man3/resolver_r.3
+++ b/man3/resolver_r.3
@@ -13,7 +13,8 @@ res_nsend \- reentrant resolver routines
 .nf
 .B #include <resolv.h>
 .sp
-.B typedef struct state *res_state;
+.B struct __res_state;
+.B typedef struct __res_state *res_state;
 .sp
 .BI "int res_ninit(res_state " statep ");"
 .sp
-- 
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-07-04  5:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04  5:18 [PATCH/RFC] resolver_r.3: New page documenting res_ninit() et al Jonathan Nieder
2011-07-04  5:33 ` Jonathan Nieder [this message]
2011-07-04  9:19   ` Stefan Puiu
     [not found]     ` <CACKs7VCC_gkVEeci+ctTQ-H+YPsErN9cWb-CczvVUW5pG3zmDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-04  9:37       ` Jonathan Nieder
2011-07-04  9:48         ` Stefan Puiu
     [not found]           ` <CACKs7VB_hoonsERpihxPSW=eQVu0LYDffao37xz5G9+vAV_J0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-05 19:57             ` Stefan Puiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110704053331.GA16153@elie \
    --to=jrnieder-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=edmonds-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.kettenis-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
    --cc=tincho-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox