From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Subject: Re: Bad error return after find_vma() in PR_SET_MM code Date: Tue, 24 Apr 2012 19:15:44 +0400 Message-ID: <20120424151544.GH21224@moon> References: <4F96C2CF.5070900@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4F96C2CF.5070900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: KOSAKI Motohiro Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Pavel Emelyanov , linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , Tejun Heo , Andrew Morton List-Id: linux-man@vger.kernel.org On Tue, Apr 24, 2012 at 11:12:15AM -0400, KOSAKI Motohiro wrote: > (4/15/12 12:00 AM), Michael Kerrisk (man-pages) wrote: > >[Bother! Resending with corrected subject line (was "[PATCH 1/2] > >prctl: Add PR_SET_MM option description")] > > > >Cyrill, > > > >While reviewing your patch to the prctl() manual page, I noticed the > >following code in kernel/sys.c::prctl_set_mm(): > > > > if (opt != PR_SET_MM_START_BRK&& opt != PR_SET_MM_BRK) { > > /* It must be existing VMA */ > > if (!vma || vma->vm_start> addr) > > goto out; > > } > > > >At this point, the code causes an exit with error set to zero (i.e., > >success). This looks unintended to me. Is the code correct? I suspect > >a return of -EFAULT or -ENOMEM is warranted. > > EFAULT please when detecting invalid vma. Thanks for reminder, Kosaki! I'll cook a patch asap. Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html