From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] open(2): document O_PATH Date: Thu, 3 May 2012 15:11:56 +0100 Message-ID: <20120503141156.GP6871@ZenIV.linux.org.uk> References: <1335669917-23970-1-git-send-email-vapier@gentoo.org> <877gwxacti.fsf@skywalker.in.ibm.com> <87bom5xswc.fsf@skywalker.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87bom5xswc.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Aneesh Kumar K.V" Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Mike Frysinger , linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Richard Weinberger , lkml List-Id: linux-man@vger.kernel.org On Thu, May 03, 2012 at 07:34:35PM +0530, Aneesh Kumar K.V wrote: > I looked at dnotify_flush, they remove markers on an inode. > But then it also checks for filp to match. So I am not sure > whether skipping dnotify_flush for O_PATH descriptor have any impact. We > can't use O_PATH descriptor for dnotify fcntl any way. So in > dnotify_flush we will not match the filp. > > Viro, > > Any reason why we skip dnotify_flush ? See your last sentence above - why bother finding the mark, scanning the list, etc. when we know that there won't be any matches? -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html