From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>,
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Namjae Jeon <linkinjeon@gmail.com>,
linux-man@vger.kernel.org,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v5 10/10] manpage: update FALLOC_FL_COLLAPSE_RANGE flag in fallocate
Date: Fri, 18 Apr 2014 11:55:20 -0400 [thread overview]
Message-ID: <20140418155520.GB16490@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1404181140060.2128@localhost.localdomain>
On Fri, Apr 18, 2014 at 11:45:35AM +0200, Lukáš Czerner wrote:
>
> I'd like to point out that do_fallocate() in vfs uses ENODEV in the
> case it is not regular file nor directory.
>
> Also I thought of the EOPNOTSUP to be the right way to go. For
> example we do not support it on non-extent based files in ext4 so we
> return EOPNOTSUP.
>
> The same is for the case that we do not support the particular
> fallocate mode.
>
> So I am not really sure about what's the right error to use.
Yes, there is some inconsistency here. I'll change this particular
case (a non-REGULAR file to use EINVAL) to be consistent with xfs, but
I suspect programs are going to have to be flexible.
As far as non-extent based files, at least in theory at some point we
could support COLLAPSE_RANGE on regular files, so I'll leave it as
EOPNOTSUPP for now, but the choice is admittedly somewhat arbitrary.
Cheers,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-18 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1392741594-20335-1-git-send-email-linkinjeon@gmail.com>
[not found] ` <1392741594-20335-1-git-send-email-linkinjeon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-16 6:05 ` [PATCH v5 10/10] manpage: update FALLOC_FL_COLLAPSE_RANGE flag in fallocate Christoph Hellwig
[not found] ` <20140416060510.GA25651-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-04-17 13:40 ` Michael Kerrisk (man-pages)
2014-04-17 15:59 ` Christoph Hellwig
[not found] ` <20140417155959.GA24231-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-04-17 20:11 ` Michael Kerrisk (man-pages)
[not found] ` <CAKgNAkgis+LvQeiabWaRbb3=rvEV2_Z_XQ8O6d5JGR=eEFSxCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-17 22:23 ` Christoph Hellwig
[not found] ` <534FD9B5.3000207-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-17 22:57 ` Dave Chinner
2014-04-18 9:45 ` Lukáš Czerner
2014-04-18 15:55 ` Theodore Ts'o [this message]
2014-04-19 6:16 ` Michael Kerrisk (man-pages)
2014-04-18 15:41 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418155520.GB16490@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).