linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Casasnovas <quentin.casasnovas-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Denys Vlasenko <dvlasenk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Michael Kerrisk (man-pages)"
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Vegard Nossum
	<vegard.nossum-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Quentin Casasnovas
	<quentin.casasnovas-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: ptrace.2: BUGS (missing WIFEXITED notification)
Date: Thu, 14 May 2015 18:28:07 +0200	[thread overview]
Message-ID: <20150514162807.GA13385@chrystal.uk.oracle.com> (raw)
In-Reply-To: <5554A8A4.7060404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Thu, May 14, 2015 at 03:52:36PM +0200, Denys Vlasenko wrote:
> On 05/14/2015 03:44 PM, Michael Kerrisk (man-pages) wrote:
> > Hi Denys,
> > 
> > Do you have any thoughts on the below?
> 
> Yes, the poster is right: this part needs fixing, the behavior is
> the same on any kind of process termination.
> 
> 
> > On 05/12/2015 04:31 PM, Vegard Nossum wrote:
> >> We hit another edge case in the ptrace() interface and after several
> >> hours of chasing it down, we found that it was already described in the
> >> "BUGS" section:
> >>
> >> "If a thread group leader is traced and exits by calling _exit(2), a
> 
> I think a possible fix is just to replace "exits by calling _exit(2)" part
> of the above text with "terminates".
> 

Should we also add a little paragraph detailing that waitpid() would hang
indefinitely if one thread terminates while the others are in ptrace-stop?
This behaviour was quite puzzling as during our experiments,
waitpid(<thread_pid>, ...) was hanging on a zombie thread, and even using
waitpid(-1, ...)  wasn't helping.

The only way for us to work-around this behaviour was to have
PTRACE_O_TRACEEXIT and detach from the threads when we were notified of a
thread termination, without PTRACE_O_TRACEEXIT I don't think one can be
notified in way, leading to hangs almost certainly when tracing multiple
threads and some are in ptrace-stop.

Or maybe that's obvious from the following sentence:

"If a thread group leader is traced and exits by calling _exit(2), a
PTRACE_EVENT_EXIT stop will happen for it (if requested), but the
subsequent WIFEXITED notification will not be delivered until all other
threads exit."

I know we didn't realize the other threads would not exit (because they
were in ptrace-stop), blocking the delivery.

Quentin
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-05-14 16:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 14:31 ptrace.2: BUGS (missing WIFEXITED notification) Vegard Nossum
     [not found] ` <55520EAC.2010003-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-05-14 13:44   ` Michael Kerrisk (man-pages)
     [not found]     ` <5554A6B0.2090409-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 13:52       ` Denys Vlasenko
     [not found]         ` <5554A8A4.7060404-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-14 16:28           ` Quentin Casasnovas [this message]
     [not found]             ` <20150514162807.GA13385-Cuu6V/XUcleLI2c71l+0mdkmqwFzkYv6@public.gmane.org>
2015-05-14 16:39               ` Denys Vlasenko
     [not found]                 ` <5554CFDF.6070602-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-14 16:50                   ` Quentin Casasnovas
     [not found]                     ` <20150514165031.GB13385-Cuu6V/XUcleLI2c71l+0mdkmqwFzkYv6@public.gmane.org>
2015-05-14 17:06                       ` Denys Vlasenko
     [not found]                         ` <5554D5F8.8050305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-14 17:41                           ` Quentin Casasnovas
2015-05-15 10:12                   ` Vegard Nossum
     [not found]                     ` <5555C69A.3070509-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-05-15 12:05                       ` Michael Kerrisk (man-pages)
     [not found]                         ` <CAKgNAkixHtPEdmwuVhic8k2gz8ooLmW1rJ3760oWGUC07K-5hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-18  6:49                           ` Michael Kerrisk (man-pages)
     [not found]                             ` <55826A17.8000804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-12 14:50                               ` Vegard Nossum
     [not found]                                 ` <57ADE23B.8050905-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-08-12 16:15                                   ` Denys Vlasenko
     [not found]                                     ` <864524d3-6a7f-9555-b4a4-eb4816c4da18-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-12 18:37                                       ` Vegard Nossum
     [not found]                                         ` <57AE1750.50303-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-08-12 19:11                                           ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514162807.GA13385@chrystal.uk.oracle.com \
    --to=quentin.casasnovas-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=dvlasenk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=vegard.nossum-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).