From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH 1/2] man2: document FICLONE and FICLONERANGE Date: Thu, 28 Jan 2016 11:18:14 -0800 Message-ID: <20160128191814.GA5849@birch.djwong.org> References: <20151219085607.12660.75196.stgit@birch.djwong.org> <20151219085613.12660.75735.stgit@birch.djwong.org> <20160128133329.GA7610@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160128133329.GA7610-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-man@vger.kernel.org On Thu, Jan 28, 2016 at 05:33:29AM -0800, Christoph Hellwig wrote: > Now that we have this in 4.5-rc1 let's get this into man-pages as well. > > > --- /dev/null > > +++ b/man2/ioctl_ficlone.2 > > think this should be a link to the clone range man page, and the > both ioctls should be documented together. Basically just document > FICLONERANGE and then mentiond that FICLONE does a whole file clone. Ok, that's an easy switch to make. > > +.B #include > > Don't we need uapi/linux/fs.h as well? Err... yes. :) > > Not all filesystems support > > +overlapping reflink ranges in the same file. > > Which one doesn't? At the moment, neither btrfs nor XFS support it. I don't think it'd be difficult for XFS (make a copy of the extent mappings in the source area, increase the refcounts of those blocks, do the usual punch-and-remap, then delete & decrement that copy of the mappings) but that can come later. > Also there should be a sentence that the clones are atomic vs > concurrent writes, so no locks need to be taken for a consistent > snapshot. I've updated the manpages and will repush the patchset ... optimistically, when XFS reflink RFCv5 comes out, but sooner if anyone requests it. :) Thank you for the review! --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html