Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

Here are more informations to save you the time searching for it.
Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:

+#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
+    || defined __USE_XOPEN2K8
[..]
extern int mkstemp (char *__template) __nonnull ((1)) __wur;

And in include/features.h (from glibc 2.12 e28c887):

#if (_POSIX_C_SOURCE - 0) >= 200112L
# define __USE_XOPEN2K		1
# undef __USE_ISOC95
# define __USE_ISOC95		1
# undef __USE_ISOC99
# define __USE_ISOC99		1
#endif

#if (_POSIX_C_SOURCE - 0) >= 200809L
# define __USE_XOPEN2K8		1
# undef  _ATFILE_SOURCE
# define _ATFILE_SOURCE	1
#endif

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

*ping*

Forgive me for being insistant, but as there has been no response to
this thread, and with all the spam thas has been going on on the ml in
the last few days, I'm thinking maybe you didn't see it pass.
Or maybe you just don't find it acceptable, then a response would be
appreciated anyway.
Thanks for your time!

> Here are more informations to save you the time searching for it.
> Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
> 
> +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
> +    || defined __USE_XOPEN2K8
> [..]
> extern int mkstemp (char *__template) __nonnull ((1)) __wur;
> 
> And in include/features.h (from glibc 2.12 e28c887):
> 
> #if (_POSIX_C_SOURCE - 0) >= 200112L
> # define __USE_XOPEN2K		1
> # undef __USE_ISOC95
> # define __USE_ISOC95		1
> # undef __USE_ISOC99
> # define __USE_ISOC99		1
> #endif
> 
> #if (_POSIX_C_SOURCE - 0) >= 200809L
> # define __USE_XOPEN2K8		1
> # undef  _ATFILE_SOURCE
> # define _ATFILE_SOURCE	1
> #endif
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

*ping*

> *ping*
> 
> Forgive me for being insistant, but as there has been no response to
> this thread, and with all the spam thas has been going on on the ml in
> the last few days, I'm thinking maybe you didn't see it pass.
> Or maybe you just don't find it acceptable, then a response would be
> appreciated anyway.
> Thanks for your time!
> 
> > Here are more informations to save you the time searching for it.
> > Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
> > 
> > +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
> > +    || defined __USE_XOPEN2K8
> > [..]
> > extern int mkstemp (char *__template) __nonnull ((1)) __wur;
> > 
> > And in include/features.h (from glibc 2.12 e28c887):
> > 
> > #if (_POSIX_C_SOURCE - 0) >= 200112L
> > # define __USE_XOPEN2K		1
> > # undef __USE_ISOC95
> > # define __USE_ISOC95		1
> > # undef __USE_ISOC99
> > # define __USE_ISOC99		1
> > #endif
> > 
> > #if (_POSIX_C_SOURCE - 0) >= 200809L
> > # define __USE_XOPEN2K8		1
> > # undef  _ATFILE_SOURCE
> > # define _ATFILE_SOURCE	1
> > #endif
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man"
> in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

*ping*

> *ping*
> 
> > *ping*
> > 
> > Forgive me for being insistant, but as there has been no response to
> > this thread, and with all the spam thas has been going on on the ml in
> > the last few days, I'm thinking maybe you didn't see it pass.
> > Or maybe you just don't find it acceptable, then a response would be
> > appreciated anyway.
> > Thanks for your time!
> > 
> > > Here are more informations to save you the time searching for it.
> > > Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
> > > 
> > > +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
> > > +    || defined __USE_XOPEN2K8
> > > [..]
> > > extern int mkstemp (char *__template) __nonnull ((1)) __wur;
> > > 
> > > And in include/features.h (from glibc 2.12 e28c887):
> > > 
> > > #if (_POSIX_C_SOURCE - 0) >= 200112L
> > > # define __USE_XOPEN2K		1
> > > # undef __USE_ISOC95
> > > # define __USE_ISOC95		1
> > > # undef __USE_ISOC99
> > > # define __USE_ISOC99		1
> > > #endif
> > > 
> > > #if (_POSIX_C_SOURCE - 0) >= 200809L
> > > # define __USE_XOPEN2K8		1
> > > # undef  _ATFILE_SOURCE
> > > # define _ATFILE_SOURCE	1
> > > #endif
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > > linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html  
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-man"
> > in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-man" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 08 Jul 2016 02:06, Quentin Rameau wrote:
> Here are more informations to save you the time searching for it.
> Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
> 
> +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
> +    || defined __USE_XOPEN2K8
> [..]
> extern int mkstemp (char *__template) __nonnull ((1)) __wur;
> 
> And in include/features.h (from glibc 2.12 e28c887):
> 
> #if (_POSIX_C_SOURCE - 0) >= 200112L
> # define __USE_XOPEN2K		1
> # undef __USE_ISOC95
> # define __USE_ISOC95		1
> # undef __USE_ISOC99
> # define __USE_ISOC99		1
> #endif
> 
> #if (_POSIX_C_SOURCE - 0) >= 200809L
> # define __USE_XOPEN2K8		1
> # undef  _ATFILE_SOURCE
> # define _ATFILE_SOURCE	1
> #endif

what is it you're trying to report ?  the man page already reads:
       mkstemp():
           _XOPEN_SOURCE >= 500
               || /* Since glibc 2.12: */ _POSIX_C_SOURCE >= 200112L
               || /* Glibc versions <= 2.19: */ _SVID_SOURCE || _BSD_SOURCE

can you attach a patch ?
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

Hi, thanks for the response!

> On 08 Jul 2016 02:06, Quentin Rameau wrote:
> > Here are more informations to save you the time searching for it.
> > Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
> > 
> > +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
> > +    || defined __USE_XOPEN2K8
> > [..]
> > extern int mkstemp (char *__template) __nonnull ((1)) __wur;
> > 
> > And in include/features.h (from glibc 2.12 e28c887):
> > 
> > #if (_POSIX_C_SOURCE - 0) >= 200112L
> > # define __USE_XOPEN2K		1
> > # undef __USE_ISOC95
> > # define __USE_ISOC95		1
> > # undef __USE_ISOC99
> > # define __USE_ISOC99		1
> > #endif
> > 
> > #if (_POSIX_C_SOURCE - 0) >= 200809L
> > # define __USE_XOPEN2K8		1
> > # undef  _ATFILE_SOURCE
> > # define _ATFILE_SOURCE	1
> > #endif
> 
> what is it you're trying to report ?  the man page already reads:
>        mkstemp():
>            _XOPEN_SOURCE >= 500
>                || /* Since glibc 2.12: */ _POSIX_C_SOURCE >= 200112L
>                || /* Glibc versions <= 2.19: */ _SVID_SOURCE || _BSD_SOURCE

Yes, that's the whole point, it is incorrect!
mkstemp is declared with __USE_XOPEN2K8 defined, which occurs when
_POSIX_C_SOURCE is defined to 200809L, not 200112L as it is incorrectly
stated in the current manpage version.

> can you attach a patch ?
> -mike

Of course, already did that in fact, that's the first mail of the
thread.
I can link the marc.info archive to you if that can help:
http://marc.info/?l=linux-man&m=146737548209893

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Michael Kerrisk (man-pages)]

Hello Quentin

For some reasons, all of your earlier mails got marked as spam by
gmail, and so I did not see them. However, Mike's reply came through
okay, and so I saw this at last.

On 08/03/2016 09:31 PM, Quentin Rameau wrote:
> Hi, thanks for the response!
>
>> On 08 Jul 2016 02:06, Quentin Rameau wrote:
>>> Here are more informations to save you the time searching for it.
>>> Introduced in f095bb7 (2010-01-09) in stdlib/stdlib.h line 609:
>>>
>>> +#if defined __USE_MISC || defined __USE_XOPEN_EXTENDED \
>>> +    || defined __USE_XOPEN2K8
>>> [..]
>>> extern int mkstemp (char *__template) __nonnull ((1)) __wur;
>>>
>>> And in include/features.h (from glibc 2.12 e28c887):
>>>
>>> #if (_POSIX_C_SOURCE - 0) >= 200112L
>>> # define __USE_XOPEN2K		1
>>> # undef __USE_ISOC95
>>> # define __USE_ISOC95		1
>>> # undef __USE_ISOC99
>>> # define __USE_ISOC99		1
>>> #endif
>>>
>>> #if (_POSIX_C_SOURCE - 0) >= 200809L
>>> # define __USE_XOPEN2K8		1
>>> # undef  _ATFILE_SOURCE
>>> # define _ATFILE_SOURCE	1
>>> #endif
>>
>> what is it you're trying to report ?  the man page already reads:
>>        mkstemp():
>>            _XOPEN_SOURCE >= 500
>>                || /* Since glibc 2.12: */ _POSIX_C_SOURCE >= 200112L
>>                || /* Glibc versions <= 2.19: */ _SVID_SOURCE || _BSD_SOURCE
>
> Yes, that's the whole point, it is incorrect!
> mkstemp is declared with __USE_XOPEN2K8 defined, which occurs when
> _POSIX_C_SOURCE is defined to 200809L, not 200112L as it is incorrectly
> stated in the current manpage version.
>
>> can you attach a patch ?
>> -mike
>
> Of course, already did that in fact, that's the first mail of the
> thread.
> I can link the marc.info archive to you if that can help:
> http://marc.info/?l=linux-man&m=146737548209893

Thanks for catching this. I've applied your patch.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

On Thu, Aug 04, 2016 at 08:17:29AM +1000, Michael Kerrisk (man-pages) wrote:
> Hello Quentin
> 
> For some reasons, all of your earlier mails got marked as spam by
> gmail, and so I did not see them. However, Mike's reply came through
> okay, and so I saw this at last.

No problem, indeed that happens!

> Thanks for catching this. I've applied your patch.

Thanks to you!
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

On 03 Aug 2016 13:31, Quentin Rameau wrote:
> > can you attach a patch ?
> 
> Of course, already did that in fact, that's the first mail of the
> thread.

i replied to the first e-mail in the thread that i saw which didn't
include a patch
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] mkstemp: fix _POSIX_C_SOURCE value for mkstemp()

[Quentin Rameau]

The correct _POSIX_C_SOURCE value has always been 200809L, not 200112L
---
 man3/mkstemp.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/mkstemp.3 b/man3/mkstemp.3
index 8fcd608..d1d4805 100644
--- a/man3/mkstemp.3
+++ b/man3/mkstemp.3
@@ -59,7 +59,7 @@ Feature Test Macro Requirements for glibc (see
 .PD 0
 _XOPEN_SOURCE\ >=\ 500
 .\"    || _XOPEN_SOURCE\ &&\ _XOPEN_SOURCE_EXTENDED
-    || /* Since glibc 2.12: */ _POSIX_C_SOURCE\ >=\ 200112L
+    || /* Since glibc 2.12: */ _POSIX_C_SOURCE\ >=\ 200809L
     || /* Glibc versions <= 2.19: */ _SVID_SOURCE || _BSD_SOURCE
 .PD
 .RE
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html