linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jann Horn <jann-XZ1E9jl8jIdeoWH0uzbU5w@public.gmane.org>
Cc: "Michael Kerrisk (man-pages)"
	<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Iago López Galeiras"
	<iago-973cpzSjLbNWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] proc.5: document /proc/[pid]/task/[tid]/children
Date: Sun, 14 Aug 2016 11:40:26 +0300	[thread overview]
Message-ID: <20160814084026.GA1857@uranus.lan> (raw)
In-Reply-To: <20160803225254.GA14948-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>

On Thu, Aug 04, 2016 at 12:52:54AM +0200, Jann Horn wrote:
...
> > 
> > Thanks for this! I tweaked your text somewhat, and added some
> > details about kernel configuration options, so that now the text
> > reads:
> > 
> >        /proc/[pid]/task/[tid]/children (since Linux 3.5)
> >               A  space-separated  list  of child tasks of this task.
> >               Each child task is represented by its TID.
> > 
> >               This option is intended for  use  by  the  checkpoint-
> >               restore (CRIU) system, and reliably provides a list of
> >               children only  if  all  of  the  child  processes  are
> >               stopped or frozen.  It does not work properly if chil‐
> >               dren of the target task exit while the file  is  being
> >               read!  Exiting children may cause non-exiting children
> >               to be omitted from the list.  This makes  this  inter‐
> >               face  even  more  unreliable  than  classic  PID-based
> >               approaches if the  inspected  task  and  its  children
> >               aren't  frozen,  and most code should probably not use
> >               this interface.

Hi! First of all, sorry for delay. Guys, this is not really true. The same
applies to plain "ls /proc". You can fetch pid from the procfs and then
process get dead just right after you've finished reading. So this interface
works "properly" all the time, but if one needs precise results it should
stop/freeze processes first. In contrary I think it worth switching into
children interface in user-space programs because it incredibly fast.

> > 
> >               Until Linux 4.2, the presence of this  file  was  gov‐
> >               erned by the CONFIG_CHECKPOINT_RESTORE kernel configu‐
> >               ration option.  Since Linux 4.2, it it is governed  by
> >               the CONFIG_PROC_CHILDREN option.
> > 
> > Look okay?
> 
> Looks good to me.



	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-08-14  8:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  0:25 [PATCH] proc.5: document /proc/[pid]/task/[tid]/children Jann Horn
     [not found] ` <b97bbf47-1180-0d32-ba08-1482020cc883@gmail.com>
     [not found]   ` <b97bbf47-1180-0d32-ba08-1482020cc883-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-03 22:52     ` Jann Horn
     [not found]       ` <20160803225254.GA14948-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>
2016-08-14  8:40         ` Cyrill Gorcunov [this message]
     [not found]           ` <20160814084026.GA1857-ZmlpmtaulQd+urZeOPWqwQ@public.gmane.org>
2016-08-14 10:48             ` Jann Horn
     [not found]               ` <20160814104856.GA12246-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>
2016-08-14 20:14                 ` Cyrill Gorcunov
     [not found]                   ` <20160814201441.GC1857-ZmlpmtaulQd+urZeOPWqwQ@public.gmane.org>
2016-08-14 20:46                     ` Jann Horn
     [not found]                       ` <20160814204635.GA2803-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>
2016-08-14 22:13                         ` Cyrill Gorcunov
     [not found]                           ` <20160814221359.GD1857-ZmlpmtaulQd+urZeOPWqwQ@public.gmane.org>
2016-08-14 22:45                             ` Jann Horn
     [not found]                               ` <20160814224546.GA32168-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>
2016-08-15  8:50                                 ` Cyrill Gorcunov
     [not found]                                   ` <20160815085004.GE1857-ZmlpmtaulQd+urZeOPWqwQ@public.gmane.org>
2016-08-15 11:53                                     ` Jann Horn
     [not found]                                       ` <20160815115333.GA11115-J1fxOzX/cBvk1uMJSBkQmQ@public.gmane.org>
2016-08-15 12:34                                         ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160814084026.GA1857@uranus.lan \
    --to=gorcunov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=iago-973cpzSjLbNWk0Htik3J/w@public.gmane.org \
    --cc=jann-XZ1E9jl8jIdeoWH0uzbU5w@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).