From: Mike Rapoport <rppt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Andrea Arcangeli <aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Michael Kerrisk
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Dr. David Alan Gilbert"
<dgilbert-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ioctl_userfaultfd.2: update uffdio_api.features description
Date: Thu, 29 Jun 2017 14:16:22 +0300 [thread overview]
Message-ID: <20170629111621.GC24911@rapoport-lnx> (raw)
In-Reply-To: <20170628141112.GI7050-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Wed, Jun 28, 2017 at 04:11:12PM +0200, Andrea Arcangeli wrote:
> On Wed, Jun 28, 2017 at 03:30:03PM +0300, Mike Rapoport wrote:
>
> On a side note, as mentioned some time ago, if UFFDIO_API returns
> -EINVAL the uffdio_api userland structure gets clobbered with zeros by
> the kernel purely for robustness. So the "features" field is to be
> considered a meaningful output, only if UFFDIO_API ioctl succeeds and
> returns 0.
That reminded me that there was a bunch of comments from Andrea a while
ago [1]...
Michael, can you please review that thread?
If you need any help from my side, don't hesitate to ping me.
> Thanks,
> Andrea
>
[1] https://lkml.org/lkml/2017/5/3/594
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-29 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 12:30 [PATCH] ioctl_userfaultfd.2: update uffdio_api.features description Mike Rapoport
[not found] ` <1498653003-25227-1-git-send-email-rppt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 14:11 ` Andrea Arcangeli
[not found] ` <20170628141112.GI7050-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-06-29 11:16 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629111621.GC24911@rapoport-lnx \
--to=rppt-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dgilbert-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox