From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yubin Ruan Subject: Re: [PATCTH 0/2] pthread_mutexattr_setrobust() and pthread_mutex_consistent() Date: Fri, 15 Sep 2017 17:45:00 +0800 Message-ID: <20170915094414.GA18043@HP.internal.baidu.com> References: <36ab9ec0-b496-c007-c12f-065fd618e7fd@gmail.com> <20170826210528.GA32472@HP.internal.baidu.com> <1159fa2e-006e-d3dd-7d1b-0e055cad42b5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1159fa2e-006e-d3dd-7d1b-0e055cad42b5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Michael Kerrisk (man-opages)" Cc: linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, libc-alpha-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org List-Id: linux-man@vger.kernel.org On Wed, Sep 13, 2017 at 05:00:11PM +0200, Michael Kerrisk (man-opages) wrote: > Hi Yubin > > >Hi Michael, > > > >Sorry that it took so long. > > > >Following is the renew patch. I have corrected several formatting issues (i.e., > >\n , - , but I can't find anything wrong with ' ) and some typos. The only > >issue I cannot solve is that the new `pthread_mutex_consistent(3)` page is too > >short that it shows at the very bottom... please help with this. > > > >Also, please find attached three verification snippets. > > I've done some heavy editing, and added quite a few pieces to these pages, > and pushed the results to Git. Go take a look and let me know > of anything you think needs fixing. Thanks for these pages! Good job. No objection, except a minor change and some code formatting change. See the diff below. Yubin diff --git a/man3/pthread_mutexattr_setrobust.3 b/man3/pthread_mutexattr_setrobust.3 index e9e8e76..66b4bed 100644 --- a/man3/pthread_mutexattr_setrobust.3 +++ b/man3/pthread_mutexattr_setrobust.3 @@ -86,7 +86,7 @@ on the mutex will block indefinitely. .TP .B PTHREAD_MUTEX_ROBUST If a mutex is initialized with the -.BR PTHREAD_MUTEX_ROBUST , +.BR PTHREAD_MUTEX_ROBUST attribute and its owner dies without unlocking it, any future attempts to call .BR pthread_mutex_lock (3) @@ -255,22 +255,21 @@ main(int argc, char *argv[]) s = pthread_mutex_lock(&mtx); if (s == EOWNERDEAD) { printf("[main thread] pthread_mutex_lock() returned EOWNERDEAD\\n"); - printf("[main thread] Now make the mutex consistent\\n"); + printf("[main thread] Now make the mutex consistent\\n"); s = pthread_mutex_consistent(&mtx); if (s != 0) - handle_error_en(s, "pthread_mutex_consistent"); - printf("[main thread] Mutex is now consistent; unlocking\\n"); + handle_error_en(s, "pthread_mutex_consistent"); + printf("[main thread] Mutex is now consistent; unlocking\\n"); s = pthread_mutex_unlock(&mtx); if (s != 0) - handle_error_en(s, "pthread_mutex_unlock");