From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: cgroups(7): documenting cgroups v2 thread mode Date: Wed, 10 Jan 2018 14:29:13 -0800 Message-ID: <20180110222913.GH3460072@devbig577.frc2.facebook.com> References: <20180109211000.GT3668920@devbig577.frc2.facebook.com> <5c9ea5dd-12dc-99d6-7905-40fdbc34e6ae@gmail.com> <20180110144708.GC3668920@devbig577.frc2.facebook.com> <704d0cd5-0bab-f876-a09c-9d60e9d2ef93@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <704d0cd5-0bab-f876-a09c-9d60e9d2ef93-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Michael Kerrisk (man-pages)" Cc: Peter Zijlstra , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lkml , linux-man , "Serge E. Hallyn" , Mike Galbraith , Li Zefan , Ingo Molnar , Paul Turner , kernel-team-b10kYP2dOMg@public.gmane.org, Andy Lutomirski , Johannes Weiner , Lauro Venancio , Waiman Long List-Id: linux-man@vger.kernel.org Hello, On Wed, Jan 10, 2018 at 11:18:48PM +0100, Michael Kerrisk (man-pages) wrote: > Ahh yes. Now I understand. I made the description of the containment > rules for cgroup.threads more explicit in the text: > > As with writing to cgroup.procs, some containment rules apply when > writing to the cgroup.threads file: > > * The writer must have write permission on the cgroup.threads > file in the destination cgroup. > > * The writer must have write permission on the cgroup.procs file > in the common ancestor of the source and destination cgroups. > (In some cases, the common ancestor may be the source or desti‐ > nation cgroup itself.) > > * The source and destination cgroups must be in the same threaded > subtree. (Outside a threaded subtree, an attempt to move a > thread by writing its thread ID to the cgroup.threads in a dif‐ > ferent domain cgroup fails with the error EOPNOTSUPP.) > > Okay? (I realize that the last bullet point is a rather different way of > formulating your idea that "the only extra restriction is that the domain > cgroup must be the same for the source and destination". But I think the > reformulation is easier to understand, no?) It looks great to me. Me explaining that way is mostly from internal / conceptual POV. Yours is definitely more approachable. Thanks. -- tejun