From: "G. Branden Robinson" <g.branden.robinson@gmail.com>
To: Don Brace <don.brace@microsemi.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
Kevin.Barnett@microchip.com, scott.teel@microchip.com,
Justin.Lindley@microchip.com, scott.benesh@microchip.com,
bader.alisaleh@microchip.com, gerry.morong@microchip.com,
mahesh.rajashekhara@microchip.com
Subject: Re: [PATCH V2 3/6] smartpqi: add module param expose ld first
Date: Sat, 24 Aug 2019 11:33:32 +1000 [thread overview]
Message-ID: <20190824013329.lozyyuiv3qe57jyu@localhost.localdomain> (raw)
In-Reply-To: <156658017256.6969.6788339572032916967.stgit@brunhilda>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
At 2019-08-23T12:09:32-0500, Don Brace wrote:
> @@ -82,6 +83,7 @@ Specifies the action the driver takes when a controller
> lockup is detected.
> The default action is
> .BR none .
> +.TP
> .TS
> l l
> ---
Can you explain the purpose of the above change?
Your subsequent patch to correct the table, by reformatting it using
tabs instead of tbl(1) macros, might have been provoked by the above.
The .TP macro is for tagged paragraphs. .TP consumes the next input
line as a tag for a tagged paragraph. In man pages, .TP is often used
for definition lists.
However, because the page was being preprocessed by tbl, the .TS macro
was getting substituted with something else, and that something was
getting "eaten" by the .TP macro.
Try removing the above hunk of the patch and see if the table comes back
to life, fixed.
Regards,
Branden
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-24 1:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 17:09 [PATCH V2 0/6] smartpqi man page update Don Brace
2019-08-23 17:09 ` [PATCH V2 1/6] smartpqi: fix spelling error Don Brace
2019-08-23 17:09 ` [PATCH V2 2/6] smartpqi: update copyright Don Brace
2019-08-23 17:09 ` [PATCH V2 3/6] smartpqi: add module param expose ld first Don Brace
2019-08-24 1:33 ` G. Branden Robinson [this message]
2019-08-23 17:09 ` [PATCH V2 4/6] smartpqi: add module param to hide vsep Don Brace
2019-08-23 17:09 ` [PATCH V2 5/6] smartpqi: add sysfs entries Don Brace
2019-08-23 17:09 ` [PATCH V2 6/6] smartpqi: correct lockup action table Don Brace
2019-08-24 1:53 ` G. Branden Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824013329.lozyyuiv3qe57jyu@localhost.localdomain \
--to=g.branden.robinson@gmail.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=bader.alisaleh@microchip.com \
--cc=don.brace@microsemi.com \
--cc=gerry.morong@microchip.com \
--cc=linux-man@vger.kernel.org \
--cc=mahesh.rajashekhara@microchip.com \
--cc=mtk.manpages@gmail.com \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox