From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: mtk.manpages@gmail.com
Cc: linux-man@vger.kernel.org, Alejandro Colomar <colomar.6.4.3@gmail.com>
Subject: [PATCH] tsearch.3: Simplify type usage and remove unneeded casts
Date: Sat, 5 Sep 2020 12:50:25 +0200 [thread overview]
Message-ID: <20200905105024.163147-1-colomar.6.4.3@gmail.com> (raw)
The type of `var` is `int **`, and it will work with tsearch()
anyway because of implicit cast from `void *`, so declaring it as an
`int **` simplifies the code.
Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
man3/tsearch.3 | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/man3/tsearch.3 b/man3/tsearch.3
index 32ddb8127..65fcadc52 100644
--- a/man3/tsearch.3
+++ b/man3/tsearch.3
@@ -323,8 +323,7 @@ action(const void *nodep, VISIT which, int depth)
int
main(void)
{
- int i, *ptr;
- void *val;
+ int i, *ptr, **val;
srand(time(NULL));
for (i = 0; i < 12; i++) {
@@ -333,7 +332,7 @@ main(void)
val = tsearch((void *) ptr, &root, compare);
if (val == NULL)
exit(EXIT_FAILURE);
- else if ((*(int **) val) != ptr)
+ else if (*val != ptr)
free(ptr);
}
twalk(root, action);
--
2.28.0
next reply other threads:[~2020-09-05 10:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 10:50 Alejandro Colomar [this message]
2020-09-05 15:35 ` [PATCH] tsearch.3: Simplify type usage and remove unneeded casts Michael Kerrisk (man-pages)
2020-09-05 15:41 ` Alejandro Colomar
2020-09-05 16:10 ` [PATCH v2] " Alejandro Colomar
2020-09-05 19:42 ` Michael Kerrisk (man-pages)
2020-09-07 7:54 ` AW: " Walter Harms
2020-09-08 8:30 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905105024.163147-1-colomar.6.4.3@gmail.com \
--to=colomar.6.4.3@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox