From: Alejandro Colomar <colomar.6.4.3@gmail.com>
To: mtk.manpages@gmail.com
Cc: linux-man@vger.kernel.org, Alejandro Colomar <colomar.6.4.3@gmail.com>
Subject: [PATCH 5/7] dlopen.3: Remove unneeded cast
Date: Sat, 5 Sep 2020 17:14:59 +0200 [thread overview]
Message-ID: <20200905151501.609036-6-colomar.6.4.3@gmail.com> (raw)
In-Reply-To: <20200905151501.609036-1-colomar.6.4.3@gmail.com>
Casting `void *` to `double (*cosine)(double)` is already done
implicitly.
I had doubts about this one, but `gcc -Wall -Wextra` didn't complain
about it.
Explicitly casting can silence warnings when mistakes are made, so it's
better to remove those casts when possible.
Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
---
man3/dlopen.3 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man3/dlopen.3 b/man3/dlopen.3
index 8e18f70c0..2de358ea3 100644
--- a/man3/dlopen.3
+++ b/man3/dlopen.3
@@ -581,7 +581,7 @@ main(void)
dlerror(); /* Clear any existing error */
- cosine = (double (*)(double)) dlsym(handle, "cos");
+ cosine = dlsym(handle, "cos");
/* According to the ISO C standard, casting between function
pointers and 'void *', as done above, produces undefined results.
--
2.28.0
next prev parent reply other threads:[~2020-09-05 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 15:14 [PATCH 0/7] Remove and/or fix casts Alejandro Colomar
2020-09-05 15:14 ` [PATCH 1/7] sock_diag.7: Remove unneeded casts Alejandro Colomar
2020-09-05 15:14 ` [PATCH 2/7] pthread_sigmask.3: " Alejandro Colomar
2020-09-05 15:14 ` [PATCH 3/7] msgop.2: " Alejandro Colomar
2020-09-05 15:14 ` [PATCH 4/7] user_namespaces.7: Remove unneeded cast Alejandro Colomar
2020-09-05 15:14 ` Alejandro Colomar [this message]
2020-09-06 13:02 ` [PATCH 5/7] dlopen.3: " Michael Kerrisk (man-pages)
2020-09-06 13:22 ` Alejandro Colomar
2020-09-06 14:27 ` Alejandro Colomar
2020-09-06 15:00 ` Michael Kerrisk (man-pages)
2020-09-06 15:13 ` Michael Kerrisk (man-pages)
2020-09-06 16:43 ` Alejandro Colomar
2020-09-05 15:15 ` [PATCH 6/7] bsearch.3: Fix intermediate type and remove unneeded casts Alejandro Colomar
2020-09-05 15:15 ` [PATCH 7/7] qsort.3: Fix casts Alejandro Colomar
2020-09-06 12:59 ` [PATCH 0/7] Remove and/or fix casts Michael Kerrisk (man-pages)
2020-09-06 13:02 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905151501.609036-6-colomar.6.4.3@gmail.com \
--to=colomar.6.4.3@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox