public inbox for linux-man@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Kirmayer <sebastian@kirmayer.de>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: linux-man@vger.kernel.org
Subject: Re: [patch] getnameinfo.3: Fix _POSIX_C_SOURCE value for getaddrinfo()
Date: Sun, 22 Nov 2020 23:53:39 +0100	[thread overview]
Message-ID: <20201122225339.GA8330@kirmayer.de> (raw)
In-Reply-To: <921887e2-61ad-6212-c91b-beab3e4a7ab8@gmail.com>

Hi Michael,

On Sun, Nov 22, 2020 at 11:42:02PM +0100, Michael Kerrisk (man-pages) wrote:
> Hi Sebastian,
> 
> On 11/22/20 11:37 PM, Sebastian Kirmayer wrote:
> > The minimum value of _POSIX_C_SOURCE for getnameinfo() was mistyped as 201112L
> > (not a real POSIX version), it should be 200112L. This is the same typo that
> > was fixed for getaddrinfo.3 in commit 94db8ae1824ada8561c3dbbbed88a8a9175c4886
> > 
> > According to the current documentation, this file should not compile, but
> > it does:
> > 
> >     #define _POSIX_C_SOURCE 200112L
> >     #include <netdb.h>
> >     int (*mygetnameinfo)() = getnameinfo;
> > 
> > (If _POSIX_C_SOURCE is changed to 200111L, the program does no longer compile.)
> > 
> > man3/getnameinfo.3:
> > 
> > @@ -27,7 +27,7 @@ Feature Test Macro Requirements for glibc (see
> >  .RE
> >  .PP
> >  .BR getnameinfo ():
> > -    Since glibc 2.22: _POSIX_C_SOURCE >= 201112L
> > +    Since glibc 2.22: _POSIX_C_SOURCE >= 200112L
> >      Glibc 2.21 and earlier: _POSIX_C_SOURCE
> >  .ad b
> >  .SH DESCRIPTION
> 
> Thanks for taking the time to report, but I think you must be looking
> at a rather old version of the manual pages. It looks like that typo
> was fixed about three years ago in the Git tree!
> 
> Thanks,
> 
> Michael

Oops, I accidently wrote getaddrinfo() in the subject. I meant to write
getnameinfo(), and I'm actually referencing the commit from three years
ago fixing it for getaddrinfo().

Sebastian

  reply	other threads:[~2020-11-22 23:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 22:37 [patch] getnameinfo.3: Fix _POSIX_C_SOURCE value for getaddrinfo() Sebastian Kirmayer
2020-11-22 22:42 ` Michael Kerrisk (man-pages)
2020-11-22 22:53   ` Sebastian Kirmayer [this message]
2020-11-22 22:57     ` Michael Kerrisk (man-pages)
2020-11-22 23:05       ` Sebastian Kirmayer
2020-11-23  7:00         ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201122225339.GA8330@kirmayer.de \
    --to=sebastian@kirmayer.de \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox